From 15a3e36cd53043ab072763362d4e7557e1724fbc Mon Sep 17 00:00:00 2001
From: Sebastien Ponce <sebastien.ponce@cern.ch>
Date: Wed, 19 Feb 2020 12:07:51 +0100
Subject: [PATCH] Fixed handling of test dependencies
There was a bug in the dd4hep_add_test_reg function which was only taking into account the last dependency of a test when several were present.
On the way, dropped a double dependency in DDDB_clean_LONGTEST
---
cmake/DD4hepBuild.cmake | 2 +-
examples/DDDB/CMakeLists.txt | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/cmake/DD4hepBuild.cmake b/cmake/DD4hepBuild.cmake
index 478d0d849..04a105ae1 100644
--- a/cmake/DD4hepBuild.cmake
+++ b/cmake/DD4hepBuild.cmake
@@ -449,7 +449,7 @@ function ( dd4hep_add_test_reg test_name )
endif()
# Set test dependencies if present
foreach ( _dep ${ARG_DEPENDS} )
- set_tests_properties( t_${test_name} PROPERTIES DEPENDS t_${_dep} )
+ set_property( TEST t_${test_name} APPEND PROPERTY DEPENDS t_${_dep} )
endforeach()
endif()
endfunction()
diff --git a/examples/DDDB/CMakeLists.txt b/examples/DDDB/CMakeLists.txt
index a9f05e74d..a2c8e2e1e 100644
--- a/examples/DDDB/CMakeLists.txt
+++ b/examples/DDDB/CMakeLists.txt
@@ -256,7 +256,6 @@ dd4hep_add_test_reg( DDDB_clean_LONGTEST
DDDB_load_LONGTEST
DDDB_DeVelo_Gaudi_LONGTEST
DDDB_DeVelo_LONGTEST
- DDDB_extract_LONGTEST
REGEX_PASS "DDDB Database successfully removed"
)
--
GitLab