From 1c0d98cff8026306428668eb7dec31f52c819e16 Mon Sep 17 00:00:00 2001
From: Markus Frank <Markus.Frank@cern.ch>
Date: Tue, 11 Oct 2022 21:37:35 +0200
Subject: [PATCH] Fix python style errors

---
 DDDigi/include/DDDigi/DigiPoissonNoise.h |  2 +-
 DDDigi/include/DDDigi/DigiRandomNoise.h  |  4 ++--
 DDDigi/plugins/Components.cpp            | 28 ++++++++++++------------
 DDDigi/plugins/DigiHitHistoryDrop.cpp    | 10 ++++-----
 DDDigi/plugins/DigiRandomNoise.cpp       |  8 +++----
 DDDigi/python/DDDigiDict.C               | 20 ++++++++---------
 DDDigi/python/dddigi.py                  |  5 +++--
 DDDigi/src/DigiLockedAction.cpp          |  6 ++---
 DDDigi/src/DigiPoissonNoise.cpp          |  8 +++----
 DDDigi/src/DigiRandomGenerator.cpp       |  4 ++--
 DDDigi/src/FalphaNoise.cpp               |  2 +-
 DDDigi/test_task_queue.cpp               |  2 +-
 12 files changed, 50 insertions(+), 49 deletions(-)

diff --git a/DDDigi/include/DDDigi/DigiPoissonNoise.h b/DDDigi/include/DDDigi/DigiPoissonNoise.h
index c09c501d8..bb7d848b9 100644
--- a/DDDigi/include/DDDigi/DigiPoissonNoise.h
+++ b/DDDigi/include/DDDigi/DigiPoissonNoise.h
@@ -14,7 +14,7 @@
 #define DDDIGI_DIGIPOISSONNOISE_H
 
 /// Framework include files
-#include "DDDigi/DigiSignalProcessor.h"
+#include <DDDigi/DigiSignalProcessor.h>
 
 /// Namespace for the AIDA detector description toolkit
 namespace dd4hep {
diff --git a/DDDigi/include/DDDigi/DigiRandomNoise.h b/DDDigi/include/DDDigi/DigiRandomNoise.h
index f3f531ef7..75e637e02 100644
--- a/DDDigi/include/DDDigi/DigiRandomNoise.h
+++ b/DDDigi/include/DDDigi/DigiRandomNoise.h
@@ -14,8 +14,8 @@
 #define DDDIGI_DIGIRANDOMNOISE_H
 
 /// Framework include files
-#include "DDDigi/DigiSignalProcessor.h"
-#include "DDDigi/FalphaNoise.h"
+#include <DDDigi/DigiSignalProcessor.h>
+#include <DDDigi/FalphaNoise.h>
 
 /// Namespace for the AIDA detector description toolkit
 namespace dd4hep {
diff --git a/DDDigi/plugins/Components.cpp b/DDDigi/plugins/Components.cpp
index b36856ca8..92d97d7a2 100644
--- a/DDDigi/plugins/Components.cpp
+++ b/DDDigi/plugins/Components.cpp
@@ -12,48 +12,48 @@
 //==========================================================================
 
 // Framework include files
-#include "DD4hep/Printout.h"
-#include "DD4hep/Factories.h"
-#include "DDDigi/DigiFactories.h"
+#include <DD4hep/Printout.h>
+#include <DD4hep/Factories.h>
+#include <DDDigi/DigiFactories.h>
 
 // C/C++ include files
 #include <cerrno>
 #include <cstdlib>
 #include <sstream>
 
-#include "DDDigi/DigiInputAction.h"
+#include <DDDigi/DigiInputAction.h>
 DECLARE_DIGIEVENTACTION_NS(dd4hep::digi,DigiInputAction)
 
-#include "DDDigi/DigiROOTInput.h"
+#include <DDDigi/DigiROOTInput.h>
 DECLARE_DIGIEVENTACTION_NS(dd4hep::digi,DigiROOTInput)
 
-#include "DDDigi/DigiSynchronize.h"
+#include <DDDigi/DigiSynchronize.h>
 DECLARE_DIGIEVENTACTION_NS(dd4hep::digi,DigiSynchronize)
 
-#include "DDDigi/DigiActionSequence.h"
+#include <DDDigi/DigiActionSequence.h>
 DECLARE_DIGIEVENTACTION_NS(dd4hep::digi,DigiActionSequence)
 DECLARE_DIGIEVENTACTION_NS(dd4hep::digi,DigiParallelActionSequence)
 DECLARE_DIGIEVENTACTION_NS(dd4hep::digi,DigiSequentialActionSequence)
 
-#include "DDDigi/DigiSubdetectorSequence.h"
+#include <DDDigi/DigiSubdetectorSequence.h>
 DECLARE_DIGIEVENTACTION_NS(dd4hep::digi,DigiSubdetectorSequence)
 
-#include "DDDigi/DigiLockedAction.h"
+#include <DDDigi/DigiLockedAction.h>
 DECLARE_DIGIEVENTACTION_NS(dd4hep::digi,DigiLockedAction)
 
-#include "DDDigi/DigiSignalProcessorSequence.h"
+#include <DDDigi/DigiSignalProcessorSequence.h>
 DECLARE_DIGISIGNALPROCESSOR_NS(dd4hep::digi,DigiSignalProcessorSequence)
 
-#include "DDDigi/DigiStoreDump.h"
+#include <DDDigi/DigiStoreDump.h>
 DECLARE_DIGIEVENTACTION_NS(dd4hep::digi,DigiStoreDump)
 
-#include "DDDigi/DigiHitAttenuatorExp.h"
+#include <DDDigi/DigiHitAttenuatorExp.h>
 DECLARE_DIGIEVENTACTION_NS(dd4hep::digi,DigiHitAttenuatorExp)
 
-#include "DDDigi/DigiContainerCombine.h"
+#include <DDDigi/DigiContainerCombine.h>
 DECLARE_DIGIEVENTACTION_NS(dd4hep::digi,DigiContainerCombine)
 
-#include "DDDigi/DigiSegmentationSplitter.h"
+#include <DDDigi/DigiSegmentationSplitter.h>
 DECLARE_DIGIEVENTACTION_NS(dd4hep::digi,DigiSegmentationSplitter)
 
 
diff --git a/DDDigi/plugins/DigiHitHistoryDrop.cpp b/DDDigi/plugins/DigiHitHistoryDrop.cpp
index 04d1e694c..c3dd1b306 100644
--- a/DDDigi/plugins/DigiHitHistoryDrop.cpp
+++ b/DDDigi/plugins/DigiHitHistoryDrop.cpp
@@ -12,10 +12,10 @@
 //==========================================================================
 
 // Framework include files
-#include "DD4hep/InstanceCount.h"
-#include "DDDigi/DigiData.h"
-#include "DDDigi/DigiContext.h"
-#include "DDDigi/DigiEventAction.h"
+#include <DD4hep/InstanceCount.h>
+#include <DDDigi/DigiData.h>
+#include <DDDigi/DigiContext.h>
+#include <DDDigi/DigiEventAction.h>
 
 
 /// Namespace for the AIDA detector description toolkit
@@ -84,5 +84,5 @@ namespace dd4hep {
 }      // End namespace dd4hep
 
 
-#include "DDDigi/DigiFactories.h"
+#include <DDDigi/DigiFactories.h>
 DECLARE_DIGIEVENTACTION_NS(dd4hep::digi,DigiHitHistoryDrop)
diff --git a/DDDigi/plugins/DigiRandomNoise.cpp b/DDDigi/plugins/DigiRandomNoise.cpp
index a0b013a91..7055249a9 100644
--- a/DDDigi/plugins/DigiRandomNoise.cpp
+++ b/DDDigi/plugins/DigiRandomNoise.cpp
@@ -75,10 +75,10 @@ namespace dd4hep {
 //==========================================================================
 
 // Framework include files
-#include "DD4hep/Printout.h"
-#include "DD4hep/InstanceCount.h"
-#include "DDDigi/DigiFactories.h"
-//#include "DDDigi/DigiRandomNoise.h"
+#include <DD4hep/Printout.h>
+#include <DD4hep/InstanceCount.h>
+#include <DDDigi/DigiFactories.h>
+//#include <DDDigi/DigiRandomNoise.h>
 
 // C/C++ include files
 
diff --git a/DDDigi/python/DDDigiDict.C b/DDDigi/python/DDDigiDict.C
index 7b3947432..10f6d167f 100644
--- a/DDDigi/python/DDDigiDict.C
+++ b/DDDigi/python/DDDigiDict.C
@@ -31,16 +31,16 @@
 #pragma clang diagnostic ignored "-Woverlength-strings"
 #endif
 
-#include "DDDigi/DigiData.h"
-#include "DDDigi/DigiHandle.h"
-#include "DDDigi/DigiKernel.h"
-#include "DDDigi/DigiContext.h"
-#include "DDDigi/DigiAction.h"
-#include "DDDigi/DigiSynchronize.h"
-#include "DDDigi/DigiEventAction.h"
-#include "DDDigi/DigiInputAction.h"
-#include "DDDigi/DigiActionSequence.h"
-#include "DDDigi/DigiSignalProcessor.h"
+#include <DDDigi/DigiData.h>
+#include <DDDigi/DigiHandle.h>
+#include <DDDigi/DigiKernel.h>
+#include <DDDigi/DigiContext.h>
+#include <DDDigi/DigiAction.h>
+#include <DDDigi/DigiSynchronize.h>
+#include <DDDigi/DigiEventAction.h>
+#include <DDDigi/DigiInputAction.h>
+#include <DDDigi/DigiActionSequence.h>
+#include <DDDigi/DigiSignalProcessor.h>
 
 struct DDDigiDict  {};
 
diff --git a/DDDigi/python/dddigi.py b/DDDigi/python/dddigi.py
index acd7bb17d..f86708c5d 100644
--- a/DDDigi/python/dddigi.py
+++ b/DDDigi/python/dddigi.py
@@ -9,7 +9,8 @@
 #
 # ==========================================================================
 from __future__ import absolute_import, unicode_literals
-from dd4hep_base import *  # noqa: F403
+from dd4hep_base import *  # noqa: F401
+
 
 logger = None
 
@@ -285,4 +286,4 @@ try:
   import digitize
   Digitize = digitize.Digitize
 except Exception as X:
-  logger.error('Failed to import digitize: '+str(X))
+  logger.error('Failed to import digitize: ' + str(X))
diff --git a/DDDigi/src/DigiLockedAction.cpp b/DDDigi/src/DigiLockedAction.cpp
index b6dc49971..daa112fd8 100644
--- a/DDDigi/src/DigiLockedAction.cpp
+++ b/DDDigi/src/DigiLockedAction.cpp
@@ -12,9 +12,9 @@
 //==========================================================================
 
 // Framework include files
-#include "DD4hep/Printout.h"
-#include "DD4hep/InstanceCount.h"
-#include "DDDigi/DigiLockedAction.h"
+#include <DD4hep/Printout.h>
+#include <DD4hep/InstanceCount.h>
+#include <DDDigi/DigiLockedAction.h>
 
 // C/C++ include files
 
diff --git a/DDDigi/src/DigiPoissonNoise.cpp b/DDDigi/src/DigiPoissonNoise.cpp
index 0dbba7947..85f4ff81c 100644
--- a/DDDigi/src/DigiPoissonNoise.cpp
+++ b/DDDigi/src/DigiPoissonNoise.cpp
@@ -12,10 +12,10 @@
 //==========================================================================
 
 // Framework include files
-#include "DD4hep/InstanceCount.h"
-#include "DDDigi/DigiPoissonNoise.h"
-#include "DDDigi/DigiSegmentation.h"
-#include "DDDigi/DigiRandomGenerator.h"
+#include <DD4hep/InstanceCount.h>
+#include <DDDigi/DigiPoissonNoise.h>
+#include <DDDigi/DigiSegmentation.h>
+#include <DDDigi/DigiRandomGenerator.h>
 
 using namespace dd4hep::digi;
 
diff --git a/DDDigi/src/DigiRandomGenerator.cpp b/DDDigi/src/DigiRandomGenerator.cpp
index 984ba26d3..14a29c6cc 100644
--- a/DDDigi/src/DigiRandomGenerator.cpp
+++ b/DDDigi/src/DigiRandomGenerator.cpp
@@ -24,10 +24,10 @@
 //==========================================================================
 
 // Framework include files
-#include "DDDigi/DigiRandomGenerator.h"
+#include <DDDigi/DigiRandomGenerator.h>
 #include <Math/ProbFuncMathCore.h>
 #include <Math/SpecFuncMathCore.h>
-#include "Math/QuantFuncMathCore.h"
+#include <Math/QuantFuncMathCore.h>
 #include <cmath>
 
 
diff --git a/DDDigi/src/FalphaNoise.cpp b/DDDigi/src/FalphaNoise.cpp
index 40d085c2c..70946b816 100644
--- a/DDDigi/src/FalphaNoise.cpp
+++ b/DDDigi/src/FalphaNoise.cpp
@@ -63,7 +63,7 @@ using namespace dd4hep::detail;
 * 
 */
 
-//#include "cnoise.h"
+//#include <cnoise.h>
 #ifndef __CNOISE_H
 #define __CNOISE_H
 
diff --git a/DDDigi/test_task_queue.cpp b/DDDigi/test_task_queue.cpp
index 345f1ebfb..76ae7e9a1 100644
--- a/DDDigi/test_task_queue.cpp
+++ b/DDDigi/test_task_queue.cpp
@@ -10,7 +10,7 @@
 // Author     : M.Frank
 //
 //==========================================================================
-#include "tbb/tbb.h"
+#include <tbb/tbb.h>
 #include <iostream>
 using namespace tbb;
 using namespace std;
-- 
GitLab