From 1e5aee9a35d369a8f99029bd36732303a12d8451 Mon Sep 17 00:00:00 2001
From: Andre Sailer <andre.philippe.sailer@cern.ch>
Date: Fri, 10 Feb 2017 10:23:15 +0100
Subject: [PATCH] DDRec: fix coverity issues for Surface class

Initialise variable for surface list
remove useless calls and comment argument name to avoid unused argument warning
---
 DDRec/include/DDRec/Surface.h |  4 ++--
 DDRec/src/Surface.cpp         | 14 +++++++-------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/DDRec/include/DDRec/Surface.h b/DDRec/include/DDRec/Surface.h
index 2b44c5f8f..db5fb3992 100644
--- a/DDRec/include/DDRec/Surface.h
+++ b/DDRec/include/DDRec/Surface.h
@@ -699,11 +699,11 @@ namespace DD4hep {
       SurfaceList(const SurfaceList& other ) : std::list< ISurface* >( other ), _isOwner( false ){}
 
       /// required c'tor for extension mechanism
-      SurfaceList(const Geometry::DetElement& ){
+      SurfaceList(const Geometry::DetElement& ) : _isOwner( false ) {
         // anything to do here  ?
       }
       /// required c'tor for extension mechanism
-      SurfaceList(const SurfaceList& ,const Geometry::DetElement& ){
+      SurfaceList(const SurfaceList& ,const Geometry::DetElement& ) : _isOwner( false ) {
         // anything to do here  ?
       }
     
diff --git a/DDRec/src/Surface.cpp b/DDRec/src/Surface.cpp
index 7ea093753..98bad389f 100644
--- a/DDRec/src/Surface.cpp
+++ b/DDRec/src/Surface.cpp
@@ -30,9 +30,9 @@ namespace DD4hep {
     long64 VolSurfaceBase::id() const  { return _id ; } 
 
     const SurfaceType& VolSurfaceBase::type() const { return _type ; }
-    Vector3D VolSurfaceBase::u( const Vector3D& point ) const {  point.x() ; return _u ; }
-    Vector3D VolSurfaceBase::v(const Vector3D& point  ) const { point.x() ;  return _v ; }
-    Vector3D VolSurfaceBase::normal(const Vector3D& point ) const {  point.x() ; return _n ; }
+    Vector3D VolSurfaceBase::u(const Vector3D& /*point*/) const { return _u ; }
+    Vector3D VolSurfaceBase::v(const Vector3D& /*point*/) const { return _v ; }
+    Vector3D VolSurfaceBase::normal(const Vector3D& /*point*/) const { return _n ; }
     const Vector3D& VolSurfaceBase::origin() const { return _o ;}
 
     Vector2D VolSurfaceBase::globalToLocal( const Vector3D& point) const {
@@ -190,7 +190,7 @@ namespace DD4hep {
     }
     
 
-    double VolSurfaceBase::distance(const Vector3D& point ) const  {  point.x() ; return 1.e99 ; }
+    double VolSurfaceBase::distance(const Vector3D& /*point*/ ) const { return 1.e99 ; }
 
     /// Checks if the given point lies within the surface
     bool VolSurfaceBase::insideBounds(const Vector3D& point, double epsilon) const {
@@ -604,9 +604,9 @@ namespace DD4hep {
 
     const SurfaceType& Surface::type() const { return _type ; }
 
-    Vector3D Surface::u( const Vector3D& point ) const { point.x() ; return _u ; }
-    Vector3D Surface::v(const Vector3D& point ) const {  point.x() ; return _v ; }
-    Vector3D Surface::normal(const Vector3D& point ) const {  point.x() ; return _n ; }
+    Vector3D Surface::u(const Vector3D& /*point*/) const { return _u ; }
+    Vector3D Surface::v(const Vector3D& /*point*/) const { return _v ; }
+    Vector3D Surface::normal(const Vector3D& /*point*/) const { return _n ; }
     const Vector3D& Surface::origin() const { return _o ;}
     double Surface::innerThickness() const { return _volSurf.innerThickness() ; }
     double Surface::outerThickness() const { return _volSurf.outerThickness() ; }
-- 
GitLab