From 1fae85ccf689e7413b1cf6ffcc44ec9f302b519e Mon Sep 17 00:00:00 2001
From: Wouter Deconinck <wdconinc@gmail.com>
Date: Fri, 18 Mar 2022 19:05:36 -0500
Subject: [PATCH] edm4hep: don't add particle as parent to its daughters
Also, don't add particle as daughter to its parents.
This addresses an issue with fully duplicated entries in the parents and
daughters relations for MCParticles. After this bugfix, only a single
entry for each parents is entered in the parents relations, similar for
daughters. More demonstrated behavior in pull request comments.
BEGINRELEASENOTES
- edm4hep: don't add particle as parent to its daughters, and vice versa
ENDRELEASENOTES
---
DDG4/edm4hep/Geant4Output2EDM4hep.cpp | 2 --
1 file changed, 2 deletions(-)
diff --git a/DDG4/edm4hep/Geant4Output2EDM4hep.cpp b/DDG4/edm4hep/Geant4Output2EDM4hep.cpp
index 554937cbc..b40226540 100644
--- a/DDG4/edm4hep/Geant4Output2EDM4hep.cpp
+++ b/DDG4/edm4hep/Geant4Output2EDM4hep.cpp
@@ -354,7 +354,6 @@ void Geant4Output2EDM4hep::saveParticles(Geant4ParticleMap* particles) {
}
int iqdau = (*k).second;
auto qdau = (*mcpc)[iqdau];
- qdau.addToParents(q);
q.addToDaughters(qdau);
}
@@ -368,7 +367,6 @@ void Geant4Output2EDM4hep::saveParticles(Geant4ParticleMap* particles) {
int iqpar = (*k).second;
auto qpar = (*mcpc)[iqpar];
q.addToParents(qpar);
- qpar.addToDaughters(q);
}
}
}
--
GitLab