From 77aad6b84d6aea829848318a123a13e41ff3de2e Mon Sep 17 00:00:00 2001
From: Wouter Deconinck <wdconinc@gmail.com>
Date: Tue, 6 Feb 2024 08:07:35 -0600
Subject: [PATCH] fix: use dict.get with default empty

Co-authored-by: Andre Sailer <andre.philippe.sailer@cern.ch>
---
 DDG4/python/DDSim/DD4hepSimulation.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/DDG4/python/DDSim/DD4hepSimulation.py b/DDG4/python/DDSim/DD4hepSimulation.py
index 18a88fdf9..f63b49f41 100644
--- a/DDG4/python/DDSim/DD4hepSimulation.py
+++ b/DDG4/python/DDSim/DD4hepSimulation.py
@@ -357,9 +357,8 @@ class DD4hepSimulation(object):
          (self.action.stack, DDG4.StackingAction, kernel.stackingAction)]:
       for action_dict in action_list:
         action = DDG4_Action(kernel, action_dict["name"])
-        if 'parameter' in action_dict.keys():
-          for parameter, value in action_dict['parameter'].items():
-            setattr(action, parameter, value)
+        for parameter, value in action_dict.get('parameter', {}).items():
+          setattr(action, parameter, value)
         kernel_Action().add(action)
 
     # ----------------------------------------------------------------------------------
-- 
GitLab