From 959fdd09314bc7677606ac0a67a1b02e235b2178 Mon Sep 17 00:00:00 2001
From: Markus Frank <Markus.Frank@cern.ch>
Date: Tue, 14 Mar 2017 15:47:51 +0100
Subject: [PATCH] Fighting coverity....
---
DDDB/src/DDDBFileReader.cpp | 1 +
DDG4/src/Geant4Converter.cpp | 1 +
2 files changed, 2 insertions(+)
diff --git a/DDDB/src/DDDBFileReader.cpp b/DDDB/src/DDDBFileReader.cpp
index 3499c8da0..c2c793b43 100644
--- a/DDDB/src/DDDBFileReader.cpp
+++ b/DDDB/src/DDDBFileReader.cpp
@@ -87,6 +87,7 @@ int DD4hep::DDDB::DDDBFileReader::getObject(const std::string& system_id,
if ( done>=len ) {
return 1;
}
+ return 0;
}
::close(fid);
}
diff --git a/DDG4/src/Geant4Converter.cpp b/DDG4/src/Geant4Converter.cpp
index 11ba1e0bb..cd1c286ee 100644
--- a/DDG4/src/Geant4Converter.cpp
+++ b/DDG4/src/Geant4Converter.cpp
@@ -667,6 +667,7 @@ void* Geant4Converter::handleAssembly(const std::string& name, const TGeoNode* n
if ( assIt == info.g4AssemblyVolumes.end() ) {
printout(FATAL, "Geant4Converter", "+++ Invalid child assembly at %s : %d parent: %s child:%s",
__FILE__, __LINE__, name.c_str(), d->GetName());
+ return 0;
}
g4->placeAssembly(d,(*assIt).second,transform);
printout(m_outputLevel, "Geant4Converter", "+++ Assembly: AddPlacedAssembly : dau:%s "
--
GitLab