From b5ff351ce1dfde055195cab237897870817d8983 Mon Sep 17 00:00:00 2001
From: Markus Frank <Markus.Frank@cern.ch>
Date: Fri, 3 Mar 2023 14:46:13 +0100
Subject: [PATCH] Remove style warnings/errors
---
DDCore/src/plugins/DetElementConfig.cpp | 4 ++--
examples/ClientTests/CMakeLists.txt | 4 ++--
examples/ClientTests/scripts/MiniTel.py | 3 +--
3 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/DDCore/src/plugins/DetElementConfig.cpp b/DDCore/src/plugins/DetElementConfig.cpp
index f15fe6f12..5b1d50fc6 100644
--- a/DDCore/src/plugins/DetElementConfig.cpp
+++ b/DDCore/src/plugins/DetElementConfig.cpp
@@ -70,6 +70,6 @@ namespace {
} // End namespace dd4hep
/// Instantiate factory
-DECLARE_XML_PLUGIN(DD4hep_DetElementConfig, configure_detelement);
+DECLARE_XML_PLUGIN(DD4hep_DetElementConfig, configure_detelement)
/// Instantiate factory
-DECLARE_XML_PLUGIN(DD4hep_SensitiveDetectorConfig, configure_sensitive);
+DECLARE_XML_PLUGIN(DD4hep_SensitiveDetectorConfig, configure_sensitive)
diff --git a/examples/ClientTests/CMakeLists.txt b/examples/ClientTests/CMakeLists.txt
index d161623f5..a6cdf1ac6 100644
--- a/examples/ClientTests/CMakeLists.txt
+++ b/examples/ClientTests/CMakeLists.txt
@@ -506,7 +506,7 @@ if (DD4HEP_USE_GEANT4)
dd4hep_add_test_reg( minitel_config_region_subdet_geant4
COMMAND "${CMAKE_INSTALL_PREFIX}/bin/run_test_ClientTests.sh"
EXEC_ARGS ${Python_EXECUTABLE} ${ClientTestsEx_INSTALL}/scripts/MiniTel.py
- -batch -events 1 -geometry /examples/ClientTests/compact/WorldSettings.xml -debug
+ -batch -debug -events 1 -geometry /examples/ClientTests/compact/WorldSettings.xml
REGEX_PASS "\\+ Apply REGION settings: minitel_region_5 to volume MyLHCBdetector5."
REGEX_FAIL "Exception;EXCEPTION;ERROR"
)
@@ -515,7 +515,7 @@ if (DD4HEP_USE_GEANT4)
dd4hep_add_test_reg( minitel_config_region_world_geant4
COMMAND "${CMAKE_INSTALL_PREFIX}/bin/run_test_ClientTests.sh"
EXEC_ARGS ${Python_EXECUTABLE} ${ClientTestsEx_INSTALL}/scripts/MiniTel.py
- -batch -events 1 -geometry /examples/ClientTests/compact/WorldSettings.xml -debug
+ -batch -debug -events 1 -geometry /examples/ClientTests/compact/WorldSettings.xml
REGEX_PASS "Volume world_volume Region: DefaultRegionForTheWorld. Apply user limits from world_region"
REGEX_FAIL "Exception;EXCEPTION;ERROR"
)
diff --git a/examples/ClientTests/scripts/MiniTel.py b/examples/ClientTests/scripts/MiniTel.py
index 664cf3d17..899591761 100644
--- a/examples/ClientTests/scripts/MiniTel.py
+++ b/examples/ClientTests/scripts/MiniTel.py
@@ -9,7 +9,6 @@
#
# ==========================================================================
from __future__ import absolute_import, unicode_literals
-import sys
import DDG4
#
"""
@@ -41,7 +40,7 @@ def run():
seq, act = m.geant4.addDetectorConstruction("Geant4DetectorGeometryConstruction/ConstructGeo")
act.DebugVolumes = True
act.DebugRegions = True
- act.DebugLimits = True
+ act.DebugLimits = True
seq, act = m.geant4.addDetectorConstruction("Geant4DetectorSensitivesConstruction/ConstructSD")
m.ui.Commands = cmds
--
GitLab