From c59ba1408e631177be508608b0b1dae957e62338 Mon Sep 17 00:00:00 2001
From: Markus Frank <Markus.Frank@cern.ch>
Date: Wed, 22 May 2024 09:08:29 +0200
Subject: [PATCH] Code maintenance: change quoted include statements to angular
brackets. Add the odd licence statement
---
DDCore/include/DD4hep/AlignmentData.h | 8 +-
DDCore/include/DD4hep/AlignmentTools.h | 2 +-
DDCore/include/DD4hep/Alignments.h | 6 +-
DDCore/include/DD4hep/AlignmentsCalculator.h | 6 +-
DDCore/include/DD4hep/AlignmentsNominalMap.h | 2 +-
DDCore/include/DD4hep/AlignmentsPrinter.h | 6 +-
DDCore/include/DD4hep/AlignmentsProcessor.h | 8 +-
DDCore/include/DD4hep/Any.h | 2 +-
DDCore/include/DD4hep/CartesianGridXYZ.h | 2 +-
DDCore/include/DD4hep/CartesianGridXZ.h | 2 +-
DDCore/include/DD4hep/CartesianGridYZ.h | 2 +-
DDCore/include/DD4hep/CartesianStripX.h | 2 +-
DDCore/include/DD4hep/CartesianStripY.h | 2 +-
DDCore/include/DD4hep/CartesianStripZ.h | 5 +-
DDCore/include/DD4hep/ConditionAny.h | 2 +-
DDCore/include/DD4hep/ConditionDerived.h | 6 +-
DDCore/include/DD4hep/Conditions.h | 6 +-
DDCore/include/DD4hep/ConditionsData.h | 4 +-
DDCore/include/DD4hep/ConditionsDebug.h | 2 +-
DDCore/include/DD4hep/ConditionsListener.h | 2 +-
DDCore/include/DD4hep/ConditionsMap.h | 4 +-
DDCore/include/DD4hep/ConditionsPrinter.h | 6 +-
DDCore/include/DD4hep/ConditionsProcessor.h | 6 +-
DDCore/include/DD4hep/DD4hepUI.h | 4 +-
DDCore/include/DD4hep/DD4hepUnits.h | 16 +-
DDCore/include/DD4hep/DetElement.h | 18 +-
DDCore/include/DD4hep/DetectorData.h | 8 +-
DDCore/include/DD4hep/DetectorHelper.h | 2 +-
DDCore/include/DD4hep/DetectorImp.h | 6 +-
DDCore/include/DD4hep/DetectorLoad.h | 2 +-
DDCore/include/DD4hep/DetectorProcessor.h | 2 +-
DDCore/include/DD4hep/DetectorSelector.h | 2 +-
DDCore/include/DD4hep/DetectorTools.h | 2 +-
DDCore/include/DD4hep/Exceptions.h | 4 +-
DDCore/include/DD4hep/ExtensionEntry.h | 3 +-
DDCore/include/DD4hep/FieldTypes.h | 6 +-
DDCore/include/DD4hep/Fields.h | 4 +-
DDCore/include/DD4hep/GeoHandler.h | 5 +-
DDCore/include/DD4hep/GlobalAlignment.h | 8 +-
DDCore/include/DD4hep/Grammar.h | 4 +-
DDCore/include/DD4hep/GrammarUnparsed.h | 2 +-
DDCore/include/DD4hep/GridPhiEta.h | 4 +-
DDCore/include/DD4hep/GridRPhiEta.h | 4 +-
DDCore/include/DD4hep/Handle.h | 2 +-
DDCore/include/DD4hep/IDDescriptor.h | 4 +-
DDCore/include/DD4hep/MatrixHelpers.h | 2 +-
DDCore/include/DD4hep/Memory.h | 2 +-
DDCore/include/DD4hep/MultiSegmentation.h | 4 +-
DDCore/include/DD4hep/NoSegmentation.h | 2 +-
DDCore/include/DD4hep/ObjectExtensions.h | 2 +-
DDCore/include/DD4hep/OpaqueData.h | 2 +-
DDCore/include/DD4hep/OpaqueDataBinder.h | 2 +-
DDCore/include/DD4hep/PolarGridRPhi.h | 2 +-
DDCore/include/DD4hep/PolarGridRPhi2.h | 2 +-
DDCore/include/DD4hep/Primitives.h | 4 +-
DDCore/include/DD4hep/Printout.h | 4 +-
DDCore/include/DD4hep/Readout.h | 6 +-
DDCore/include/DD4hep/SurfaceInstaller.h | 10 +-
DDCore/include/DD4hep/TGeoUnits.h | 20 --
DDCore/include/DD4hep/VolumeProcessor.h | 4 +-
DDCore/include/DD4hep/WaferGridXY.h | 2 +-
DDCore/include/DD4hep/World.h | 2 +-
DDCore/include/DD4hep/detail/Handle.inl | 2 +-
DDCore/include/DDSegmentation/BitField64.h | 2 +-
DDCore/include/DDSegmentation/CartesianGrid.h | 2 +-
.../include/DDSegmentation/CartesianGridXY.h | 6 +-
.../DDSegmentation/CartesianGridXYStaggered.h | 6 +-
.../include/DDSegmentation/CartesianGridXYZ.h | 3 +-
.../include/DDSegmentation/CartesianGridXZ.h | 3 +-
.../include/DDSegmentation/CartesianGridYZ.h | 2 +-
.../include/DDSegmentation/CartesianStrip.h | 3 +-
.../include/DDSegmentation/CartesianStripX.h | 2 +-
.../include/DDSegmentation/CartesianStripY.h | 3 +-
.../include/DDSegmentation/CartesianStripZ.h | 2 +-
.../DDSegmentation/CylindricalSegmentation.h | 2 +-
DDCore/include/DDSegmentation/GridPhiEta.h | 3 +-
DDCore/include/DDSegmentation/GridRPhiEta.h | 2 +-
DDCore/include/DDSegmentation/HexGrid.h | 2 +-
.../DDSegmentation/MegatileLayerGridXY.h | 2 +-
.../DDSegmentation/MultiSegmentation.h | 3 +-
.../include/DDSegmentation/NoSegmentation.h | 2 +-
DDCore/include/DDSegmentation/PolarGrid.h | 2 +-
DDCore/include/DDSegmentation/PolarGridRPhi.h | 2 +-
.../include/DDSegmentation/PolarGridRPhi2.h | 2 +-
.../DDSegmentation/ProjectiveCylinder.h | 2 +-
DDCore/include/DDSegmentation/Segmentation.h | 6 +-
.../DDSegmentation/SegmentationParameter.h | 1 -
.../include/DDSegmentation/SegmentationUtil.h | 12 +-
.../include/DDSegmentation/TiledLayerGridXY.h | 2 +-
.../DDSegmentation/TiledLayerSegmentation.h | 2 +-
DDCore/include/DDSegmentation/WaferGridXY.h | 2 +-
DDCore/include/JSON/ChildValue.h | 4 +-
DDCore/include/JSON/ChildValue.inl | 4 +-
DDCore/include/JSON/Conversions.h | 2 +-
DDCore/include/JSON/Detector.h | 4 +-
DDCore/include/JSON/Dimension.h | 6 +-
DDCore/include/JSON/Dimension.inl | 4 +-
DDCore/include/JSON/Helper.h | 10 +-
DDCore/include/JSON/Printout.h | 2 +-
DDCore/include/JSON/Tags.h | 2 +-
DDCore/include/JSON/config.h | 2 +-
DDCore/include/Parsers/Exceptions.h | 2 +-
DDCore/include/Parsers/Primitives.h | 2 +-
DDCore/include/Parsers/Printout.h | 2 +-
DDCore/include/Parsers/detail/Detector.imp | 4 +-
DDCore/include/XML/Conversions.h | 2 +-
DDCore/include/XML/DocumentHandler.h | 2 +-
DDCore/include/XML/Helper.h | 6 +-
DDCore/include/XML/Printout.h | 2 +-
DDCore/include/XML/Utilities.h | 8 +-
DDCore/include/XML/VolumeBuilder.h | 6 +-
DDCore/include/XML/XML.h | 10 +-
DDCore/include/XML/XMLChildValue.h | 4 +-
DDCore/include/XML/XMLChildValue.inl | 4 +-
DDCore/include/XML/XMLDetector.h | 4 +-
DDCore/include/XML/XMLDimension.h | 6 +-
DDCore/include/XML/XMLDimension.inl | 4 +-
DDCore/include/XML/XMLElements.h | 2 +-
DDCore/include/XML/XMLParsers.h | 4 +-
DDCore/include/XML/XMLTags.h | 4 +-
DDCore/include/XML/config.h | 2 +-
DDCore/src/AlignmentsCalculator.cpp.old | 291 ------------------
DDCore/src/Handle.cpp | 4 +-
DDCore/src/IDDescriptor.cpp | 12 +-
DDCore/src/JSON/Helpers.cpp | 4 +-
DDCore/src/ObjectExtensions.cpp | 8 +-
DDCore/src/Plugins.cpp | 4 +-
DDCore/src/PropertyDictionary.h | 2 +-
DDCore/src/SegmentationsInterna.cpp | 2 +-
DDCore/src/XML/Detector.cpp | 2 +-
DDCore/src/XML/XMLElements.cpp | 26 +-
DDCore/src/XML/XMLHelpers.cpp | 8 +-
DDCore/src/XML/XMLParsers.cpp | 14 +-
DDCore/src/XML/XMLTags.cpp | 8 +-
DDCore/src/XML/tinyxml_inl.h | 2 +-
DDCore/src/XML/tinyxmlerror_inl.h | 2 +-
DDCore/src/XML/tinyxmlparser_inl.h | 2 +-
DDCore/src/gdml/DetElementCreator.cpp | 12 +-
DDCore/src/gdml/DetNominalCreator.cpp | 6 +-
DDCore/src/gdml/ImportPlainRoot.cpp | 24 +-
DDCore/src/graphics/DrawBField.cpp | 8 +-
DDCore/src/plugins/LCDD2Output.cpp | 20 +-
DDCore/src/plugins/LCDDConverter.h | 6 +-
DDCore/src/plugins/PandoraConverter.cpp | 14 +-
DDCore/src/python/PythonPlugin.cpp | 6 +-
DDCore/src/segmentations/BitField64.cpp | 12 +-
DDCore/src/segmentations/BitFieldCoder.cpp | 12 +-
DDCore/src/segmentations/CartesianGrid.cpp | 12 +-
DDCore/src/segmentations/CartesianGridXY.cpp | 14 +-
.../CartesianGridXYStaggered.cpp | 12 +-
DDCore/src/segmentations/CartesianGridXYZ.cpp | 16 +-
DDCore/src/segmentations/CartesianGridXZ.cpp | 16 +-
DDCore/src/segmentations/CartesianGridYZ.cpp | 16 +-
DDCore/src/segmentations/CartesianStrip.cpp | 12 +-
DDCore/src/segmentations/CartesianStripX.cpp | 16 +-
DDCore/src/segmentations/CartesianStripY.cpp | 15 +-
DDCore/src/segmentations/CartesianStripZ.cpp | 16 +-
.../segmentations/CylindricalSegmentation.cpp | 12 +-
DDCore/src/segmentations/GridPhiEta.cpp | 18 +-
DDCore/src/segmentations/GridRPhiEta.cpp | 17 +-
DDCore/src/segmentations/HexGrid.cpp | 4 +-
.../src/segmentations/MegatileLayerGridXY.cpp | 14 +-
.../src/segmentations/MultiSegmentation.cpp | 10 +
DDCore/src/segmentations/NoSegmentation.cpp | 15 +-
DDCore/src/segmentations/PolarGrid.cpp | 12 +-
DDCore/src/segmentations/PolarGridRPhi.cpp | 15 +-
DDCore/src/segmentations/PolarGridRPhi2.cpp | 16 +-
.../src/segmentations/ProjectiveCylinder.cpp | 17 +-
DDCore/src/segmentations/Segmentation.cpp | 12 +-
DDCore/src/segmentations/TiledLayerGridXY.cpp | 14 +-
.../segmentations/TiledLayerSegmentation.cpp | 12 +-
DDCore/src/segmentations/WaferGridXY.cpp | 16 +-
DDDigi/include/DDDigi/DigiAction.h | 26 +-
DDDigi/src/DigiAction.cpp | 7 +-
174 files changed, 640 insertions(+), 735 deletions(-)
delete mode 100644 DDCore/include/DD4hep/TGeoUnits.h
delete mode 100644 DDCore/src/AlignmentsCalculator.cpp.old
diff --git a/DDCore/include/DD4hep/AlignmentData.h b/DDCore/include/DD4hep/AlignmentData.h
index a0343a793..0fc7c7ffa 100644
--- a/DDCore/include/DD4hep/AlignmentData.h
+++ b/DDCore/include/DD4hep/AlignmentData.h
@@ -14,12 +14,12 @@
#define DD4HEP_ALIGNMENTDATA_H
// Framework include files
-#include "DD4hep/NamedObject.h"
-#include "DD4hep/DetElement.h"
-#include "DD4hep/Volumes.h"
+#include <DD4hep/NamedObject.h>
+#include <DD4hep/DetElement.h>
+#include <DD4hep/Volumes.h>
// ROOT include files
-#include "TGeoMatrix.h"
+#include <TGeoMatrix.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/AlignmentTools.h b/DDCore/include/DD4hep/AlignmentTools.h
index dcbc694f2..6832ac7cb 100644
--- a/DDCore/include/DD4hep/AlignmentTools.h
+++ b/DDCore/include/DD4hep/AlignmentTools.h
@@ -14,7 +14,7 @@
#define DD4HEP_ALIGNMENTTOOLS_H
// Framework include files
-#include "DD4hep/Alignments.h"
+#include <DD4hep/Alignments.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/Alignments.h b/DDCore/include/DD4hep/Alignments.h
index 57c70f554..bd15fe2ac 100644
--- a/DDCore/include/DD4hep/Alignments.h
+++ b/DDCore/include/DD4hep/Alignments.h
@@ -14,9 +14,9 @@
#define DD4HEP_ALIGNMENTS_H
// Framework include files
-#include "DD4hep/IOV.h"
-#include "DD4hep/Volumes.h"
-#include "DD4hep/Conditions.h"
+#include <DD4hep/IOV.h>
+#include <DD4hep/Volumes.h>
+#include <DD4hep/Conditions.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/AlignmentsCalculator.h b/DDCore/include/DD4hep/AlignmentsCalculator.h
index 7d6ab1bf6..7a4361226 100644
--- a/DDCore/include/DD4hep/AlignmentsCalculator.h
+++ b/DDCore/include/DD4hep/AlignmentsCalculator.h
@@ -14,9 +14,9 @@
#define DD4HEP_ALIGNMENTSCALCULATOR_H
// Framework include files
-#include "DD4hep/Alignments.h"
-#include "DD4hep/AlignmentData.h"
-#include "DD4hep/ConditionsMap.h"
+#include <DD4hep/Alignments.h>
+#include <DD4hep/AlignmentData.h>
+#include <DD4hep/ConditionsMap.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/AlignmentsNominalMap.h b/DDCore/include/DD4hep/AlignmentsNominalMap.h
index d75141a24..bf6bf5091 100644
--- a/DDCore/include/DD4hep/AlignmentsNominalMap.h
+++ b/DDCore/include/DD4hep/AlignmentsNominalMap.h
@@ -14,7 +14,7 @@
#define DD4HEP_ALIGNMENTSNOMINALMAP_H
// Framework include files
-#include "DD4hep/ConditionsMap.h"
+#include <DD4hep/ConditionsMap.h>
// C/C++ include files
diff --git a/DDCore/include/DD4hep/AlignmentsPrinter.h b/DDCore/include/DD4hep/AlignmentsPrinter.h
index 9b8756538..6a0346d3f 100644
--- a/DDCore/include/DD4hep/AlignmentsPrinter.h
+++ b/DDCore/include/DD4hep/AlignmentsPrinter.h
@@ -14,9 +14,9 @@
#define DD4HEP_ALIGNMENTSPRINTER_H
// Framework includes
-#include "DD4hep/Printout.h"
-#include "DD4hep/DetElement.h"
-#include "DD4hep/Alignments.h"
+#include <DD4hep/Printout.h>
+#include <DD4hep/DetElement.h>
+#include <DD4hep/Alignments.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/AlignmentsProcessor.h b/DDCore/include/DD4hep/AlignmentsProcessor.h
index 816f617d8..03e175abc 100644
--- a/DDCore/include/DD4hep/AlignmentsProcessor.h
+++ b/DDCore/include/DD4hep/AlignmentsProcessor.h
@@ -14,10 +14,10 @@
#define DD4HEP_ALIGNMENTSPROCESSOR_H
// Framework includes
-#include "DD4hep/ConditionsMap.h"
-#include "DD4hep/AlignmentData.h"
-#include "DD4hep/Alignments.h"
-#include "DD4hep/Printout.h"
+#include <DD4hep/ConditionsMap.h>
+#include <DD4hep/AlignmentData.h>
+#include <DD4hep/Alignments.h>
+#include <DD4hep/Printout.h>
// C/C++ include files
#include <memory>
diff --git a/DDCore/include/DD4hep/Any.h b/DDCore/include/DD4hep/Any.h
index 569fff21e..255def7e4 100644
--- a/DDCore/include/DD4hep/Any.h
+++ b/DDCore/include/DD4hep/Any.h
@@ -25,7 +25,7 @@ namespace dd4hep {
#else
-#include "boost/any.hpp"
+#include <boost/any.hpp>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/CartesianGridXYZ.h b/DDCore/include/DD4hep/CartesianGridXYZ.h
index 19aa339e4..f4cec8dd0 100644
--- a/DDCore/include/DD4hep/CartesianGridXYZ.h
+++ b/DDCore/include/DD4hep/CartesianGridXYZ.h
@@ -16,7 +16,7 @@
#define DD4HEP_CARTESIANGRIDXYZ_H 1
// Framework include files
-#include "DD4hep/Segmentations.h"
+#include <DD4hep/Segmentations.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/CartesianGridXZ.h b/DDCore/include/DD4hep/CartesianGridXZ.h
index 9dd585f9e..da5941188 100644
--- a/DDCore/include/DD4hep/CartesianGridXZ.h
+++ b/DDCore/include/DD4hep/CartesianGridXZ.h
@@ -16,7 +16,7 @@
#define DD4HEP_CARTESIANGRIDXZ_H 1
// Framework include files
-#include "DD4hep/Segmentations.h"
+#include <DD4hep/Segmentations.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/CartesianGridYZ.h b/DDCore/include/DD4hep/CartesianGridYZ.h
index 727d6e02f..1767b5fbe 100644
--- a/DDCore/include/DD4hep/CartesianGridYZ.h
+++ b/DDCore/include/DD4hep/CartesianGridYZ.h
@@ -16,7 +16,7 @@
#define DD4HEP_CARTESIANGRIDYZ_H 1
// Framework include files
-#include "DD4hep/Segmentations.h"
+#include <DD4hep/Segmentations.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/CartesianStripX.h b/DDCore/include/DD4hep/CartesianStripX.h
index 51630aec9..9e07ce640 100644
--- a/DDCore/include/DD4hep/CartesianStripX.h
+++ b/DDCore/include/DD4hep/CartesianStripX.h
@@ -16,7 +16,7 @@
#define DD4HEP_CARTESIANSTRIPX_H 1
// Framework include files
-#include "DD4hep/Segmentations.h"
+#include <DD4hep/Segmentations.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/CartesianStripY.h b/DDCore/include/DD4hep/CartesianStripY.h
index c318052b4..9fade74b4 100644
--- a/DDCore/include/DD4hep/CartesianStripY.h
+++ b/DDCore/include/DD4hep/CartesianStripY.h
@@ -16,7 +16,7 @@
#define DD4HEP_CARTESIANSTRIPY_H 1
// Framework include files
-#include "DD4hep/Segmentations.h"
+#include <DD4hep/Segmentations.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/CartesianStripZ.h b/DDCore/include/DD4hep/CartesianStripZ.h
index 5dbcbb9d2..e70e0ae84 100644
--- a/DDCore/include/DD4hep/CartesianStripZ.h
+++ b/DDCore/include/DD4hep/CartesianStripZ.h
@@ -16,13 +16,14 @@
#define DD4HEP_CARTESIANSTRIPZ_H 1
// Framework include files
-#include "DD4hep/Segmentations.h"
+#include <DD4hep/Segmentations.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
+
/// Namespace for base segmentations
namespace DDSegmentation {
-class CartesianStripZ;
+ class CartesianStripZ;
}
/// We need some abbreviation to make the code more readable.
diff --git a/DDCore/include/DD4hep/ConditionAny.h b/DDCore/include/DD4hep/ConditionAny.h
index d486bab6e..311467332 100644
--- a/DDCore/include/DD4hep/ConditionAny.h
+++ b/DDCore/include/DD4hep/ConditionAny.h
@@ -14,7 +14,7 @@
#define DD4HEP_CONDITIONANY_H
// Framework include files
-#include "DD4hep/Conditions.h"
+#include <DD4hep/Conditions.h>
// C/C++ include files
#include <any>
diff --git a/DDCore/include/DD4hep/ConditionDerived.h b/DDCore/include/DD4hep/ConditionDerived.h
index fda5de81a..849210210 100644
--- a/DDCore/include/DD4hep/ConditionDerived.h
+++ b/DDCore/include/DD4hep/ConditionDerived.h
@@ -14,9 +14,9 @@
#define DD4HEP_CONDITIONDERIVED_H
// Framework include files
-#include "DD4hep/Memory.h"
-#include "DD4hep/Conditions.h"
-#include "DD4hep/detail/ConditionsInterna.h"
+#include <DD4hep/Memory.h>
+#include <DD4hep/Conditions.h>
+#include <DD4hep/detail/ConditionsInterna.h>
// C/C++ include files
#include <memory>
diff --git a/DDCore/include/DD4hep/Conditions.h b/DDCore/include/DD4hep/Conditions.h
index bc9d77f0a..16880169c 100644
--- a/DDCore/include/DD4hep/Conditions.h
+++ b/DDCore/include/DD4hep/Conditions.h
@@ -14,9 +14,9 @@
#define DD4HEP_CONDITIONS_H
// Framework include files
-#include "DD4hep/IOV.h"
-#include "DD4hep/Handle.h"
-#include "DD4hep/OpaqueData.h"
+#include <DD4hep/IOV.h>
+#include <DD4hep/Handle.h>
+#include <DD4hep/OpaqueData.h>
// C/C++ include files
#include <vector>
diff --git a/DDCore/include/DD4hep/ConditionsData.h b/DDCore/include/DD4hep/ConditionsData.h
index ce7112808..06cf06fb1 100644
--- a/DDCore/include/DD4hep/ConditionsData.h
+++ b/DDCore/include/DD4hep/ConditionsData.h
@@ -14,8 +14,8 @@
#define DD4HEP_CONDITIONSDATA_H
// Framework include files
-#include "DD4hep/Objects.h"
-#include "DD4hep/Conditions.h"
+#include <DD4hep/Objects.h>
+#include <DD4hep/Conditions.h>
// C/C++ include files
#include <vector>
diff --git a/DDCore/include/DD4hep/ConditionsDebug.h b/DDCore/include/DD4hep/ConditionsDebug.h
index 47c7cfbc4..bb8e234af 100644
--- a/DDCore/include/DD4hep/ConditionsDebug.h
+++ b/DDCore/include/DD4hep/ConditionsDebug.h
@@ -14,7 +14,7 @@
#define DD4HEP_CONDITIONSDEBUG_H
// Framework include files
-#include "DD4hep/Conditions.h"
+#include <DD4hep/Conditions.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/ConditionsListener.h b/DDCore/include/DD4hep/ConditionsListener.h
index 8dea61956..925925341 100644
--- a/DDCore/include/DD4hep/ConditionsListener.h
+++ b/DDCore/include/DD4hep/ConditionsListener.h
@@ -14,7 +14,7 @@
#define DD4HEP_CONDITIONSLISTENER_H
// Framework include files
-#include "DD4hep/Conditions.h"
+#include <DD4hep/Conditions.h>
// C/C++ include files
diff --git a/DDCore/include/DD4hep/ConditionsMap.h b/DDCore/include/DD4hep/ConditionsMap.h
index 07be328a4..a3133ef0b 100644
--- a/DDCore/include/DD4hep/ConditionsMap.h
+++ b/DDCore/include/DD4hep/ConditionsMap.h
@@ -14,8 +14,8 @@
#define DD4HEP_CONDITIONSMAP_H
// Framework include files
-#include "DD4hep/Conditions.h"
-#include "DD4hep/DetElement.h"
+#include <DD4hep/Conditions.h>
+#include <DD4hep/DetElement.h>
// C/C++ include files
#include <map>
diff --git a/DDCore/include/DD4hep/ConditionsPrinter.h b/DDCore/include/DD4hep/ConditionsPrinter.h
index e0354dd4c..37f58f979 100644
--- a/DDCore/include/DD4hep/ConditionsPrinter.h
+++ b/DDCore/include/DD4hep/ConditionsPrinter.h
@@ -14,9 +14,9 @@
#define DD4HEP_CONDITIONSPRINTER_H
// Framework includes
-#include "DD4hep/Printout.h"
-#include "DD4hep/DetElement.h"
-#include "DD4hep/Conditions.h"
+#include <DD4hep/Printout.h>
+#include <DD4hep/DetElement.h>
+#include <DD4hep/Conditions.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/ConditionsProcessor.h b/DDCore/include/DD4hep/ConditionsProcessor.h
index 886c1a23a..235f8c1ed 100644
--- a/DDCore/include/DD4hep/ConditionsProcessor.h
+++ b/DDCore/include/DD4hep/ConditionsProcessor.h
@@ -14,9 +14,9 @@
#define DD4HEP_CONDITIONSPROCESSOR_H
// Framework include files
-#include "DD4hep/DetElement.h"
-#include "DD4hep/Conditions.h"
-#include "DD4hep/ConditionsMap.h"
+#include <DD4hep/DetElement.h>
+#include <DD4hep/Conditions.h>
+#include <DD4hep/ConditionsMap.h>
// C/C++ include files
#include <memory>
diff --git a/DDCore/include/DD4hep/DD4hepUI.h b/DDCore/include/DD4hep/DD4hepUI.h
index efafc0cad..c73c0ffa0 100644
--- a/DDCore/include/DD4hep/DD4hepUI.h
+++ b/DDCore/include/DD4hep/DD4hepUI.h
@@ -14,8 +14,8 @@
#define DD4HEP_DD4HEPUI_H
// Framework includes
-#include "DD4hep/Detector.h"
-#include "DD4hep/Printout.h"
+#include <DD4hep/Detector.h>
+#include <DD4hep/Printout.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/DD4hepUnits.h b/DDCore/include/DD4hep/DD4hepUnits.h
index 33ba705b6..33617654f 100644
--- a/DDCore/include/DD4hep/DD4hepUnits.h
+++ b/DDCore/include/DD4hep/DD4hepUnits.h
@@ -1,6 +1,20 @@
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+// \author Markus Frank, David Blyth
+// \date 2018-02-20
+// \version 1.0
+//
+//==========================================================================
#ifndef DD4HEP_DD4HEPUNITS_H
#define DD4HEP_DD4HEPUNITS_H
-#include "Evaluator/DD4hepUnits.h"
+#include <Evaluator/DD4hepUnits.h>
#endif
diff --git a/DDCore/include/DD4hep/DetElement.h b/DDCore/include/DD4hep/DetElement.h
index 5e42cde9e..2e913aaa7 100644
--- a/DDCore/include/DD4hep/DetElement.h
+++ b/DDCore/include/DD4hep/DetElement.h
@@ -14,14 +14,14 @@
#define DD4HEP_DETELEMENT_H
// Framework include files
-#include "DD4hep/Handle.h"
-#include "DD4hep/Callback.h"
-#include "DD4hep/Objects.h"
-#include "DD4hep/Volumes.h"
-#include "DD4hep/Readout.h"
-#include "DD4hep/Alignments.h"
-#include "DD4hep/Segmentations.h"
-#include "DD4hep/ObjectExtensions.h"
+#include <DD4hep/Handle.h>
+#include <DD4hep/Callback.h>
+#include <DD4hep/Objects.h>
+#include <DD4hep/Volumes.h>
+#include <DD4hep/Readout.h>
+#include <DD4hep/Alignments.h>
+#include <DD4hep/Segmentations.h>
+#include <DD4hep/ObjectExtensions.h>
// C/C++ include files
#include <map>
@@ -463,6 +463,6 @@ namespace dd4hep {
};
} /* End namespace dd4hep */
-#include "DD4hep/AlignmentData.h"
+#include <DD4hep/AlignmentData.h>
#endif // DD4HEP_DETELEMENT_H
diff --git a/DDCore/include/DD4hep/DetectorData.h b/DDCore/include/DD4hep/DetectorData.h
index 06c3db6b4..ae39b33ff 100644
--- a/DDCore/include/DD4hep/DetectorData.h
+++ b/DDCore/include/DD4hep/DetectorData.h
@@ -15,10 +15,10 @@
#define DD4HEP_DETECTORDATA_H
// Framework includes
-#include "DD4hep/Printout.h"
-#include "DD4hep/Detector.h"
-#include "DD4hep/ObjectExtensions.h"
-#include "DD4hep/detail/VolumeManagerInterna.h"
+#include <DD4hep/Printout.h>
+#include <DD4hep/Detector.h>
+#include <DD4hep/ObjectExtensions.h>
+#include <DD4hep/detail/VolumeManagerInterna.h>
// C/C++ include files
#include <stdexcept>
diff --git a/DDCore/include/DD4hep/DetectorHelper.h b/DDCore/include/DD4hep/DetectorHelper.h
index 8efe0836d..8bbab1624 100644
--- a/DDCore/include/DD4hep/DetectorHelper.h
+++ b/DDCore/include/DD4hep/DetectorHelper.h
@@ -14,7 +14,7 @@
#ifndef DD4HEP_DETECTORHELPER_H
#define DD4HEP_DETECTORHELPER_H
-#include "DD4hep/Detector.h"
+#include <DD4hep/Detector.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/DetectorImp.h b/DDCore/include/DD4hep/DetectorImp.h
index 37dae4c5f..982b19d3d 100644
--- a/DDCore/include/DD4hep/DetectorImp.h
+++ b/DDCore/include/DD4hep/DetectorImp.h
@@ -28,9 +28,9 @@
#endif
// Framework include files
-#include "DD4hep/DetectorData.h"
-#include "DD4hep/DetectorLoad.h"
-#include "TNamed.h"
+#include <DD4hep/DetectorData.h>
+#include <DD4hep/DetectorLoad.h>
+#include <TNamed.h>
// Forward declarations
class TGeoManager;
diff --git a/DDCore/include/DD4hep/DetectorLoad.h b/DDCore/include/DD4hep/DetectorLoad.h
index fb6205019..54efeafbb 100644
--- a/DDCore/include/DD4hep/DetectorLoad.h
+++ b/DDCore/include/DD4hep/DetectorLoad.h
@@ -14,7 +14,7 @@
#define DD4HEP_DETECTORLOAD_H
// Framework includes
-#include "DD4hep/Detector.h"
+#include <DD4hep/Detector.h>
// C/C++ include files
#include <stdexcept>
diff --git a/DDCore/include/DD4hep/DetectorProcessor.h b/DDCore/include/DD4hep/DetectorProcessor.h
index 2b693ba43..2c1503317 100644
--- a/DDCore/include/DD4hep/DetectorProcessor.h
+++ b/DDCore/include/DD4hep/DetectorProcessor.h
@@ -14,7 +14,7 @@
#define DD4HEP_DETECTORPROCESSOR_H
// Framework includes
-#include "DD4hep/DetElement.h"
+#include <DD4hep/DetElement.h>
// C/C++ include files
#include <memory>
diff --git a/DDCore/include/DD4hep/DetectorSelector.h b/DDCore/include/DD4hep/DetectorSelector.h
index 103008ef5..55ea5a0c8 100644
--- a/DDCore/include/DD4hep/DetectorSelector.h
+++ b/DDCore/include/DD4hep/DetectorSelector.h
@@ -15,7 +15,7 @@
#define DD4HEP_DETECTORSELECTOR_H
// Framework include files
-#include "DD4hep/Detector.h"
+#include <DD4hep/Detector.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/DetectorTools.h b/DDCore/include/DD4hep/DetectorTools.h
index bdf6670a4..e3c5fc50a 100644
--- a/DDCore/include/DD4hep/DetectorTools.h
+++ b/DDCore/include/DD4hep/DetectorTools.h
@@ -14,7 +14,7 @@
#define DD4HEP_DETECTORTOOLS_H
// Framework include files
-#include "DD4hep/DetElement.h"
+#include <DD4hep/DetElement.h>
// Forward declarations
class TGeoHMatrix;
diff --git a/DDCore/include/DD4hep/Exceptions.h b/DDCore/include/DD4hep/Exceptions.h
index c983bae59..428ce2818 100644
--- a/DDCore/include/DD4hep/Exceptions.h
+++ b/DDCore/include/DD4hep/Exceptions.h
@@ -17,8 +17,8 @@
// Forward declaring header for package configuration
-#include "DD4hep/config.h"
-#include "Parsers/Exceptions.h"
+#include <DD4hep/config.h>
+#include <Parsers/Exceptions.h>
#endif // DD4HEP_EXCEPTIONS_H
diff --git a/DDCore/include/DD4hep/ExtensionEntry.h b/DDCore/include/DD4hep/ExtensionEntry.h
index 98c3645c9..07b00ba10 100644
--- a/DDCore/include/DD4hep/ExtensionEntry.h
+++ b/DDCore/include/DD4hep/ExtensionEntry.h
@@ -21,7 +21,8 @@
#ifndef DD4HEP_EXTENSIONENTRY_H
#define DD4HEP_EXTENSIONENTRY_H
-#include "DD4hep/Primitives.h"
+// Framework include files
+#include <DD4hep/Primitives.h>
// C/C++ include files
#include <typeinfo>
diff --git a/DDCore/include/DD4hep/FieldTypes.h b/DDCore/include/DD4hep/FieldTypes.h
index 01b74f1e6..b689881c0 100644
--- a/DDCore/include/DD4hep/FieldTypes.h
+++ b/DDCore/include/DD4hep/FieldTypes.h
@@ -14,8 +14,10 @@
#define DD4HEP_FIELDTYPES_H
// Framework include files
-#include "DD4hep/Fields.h"
-#include "DD4hep/Shapes.h"
+#include <DD4hep/Fields.h>
+#include <DD4hep/Shapes.h>
+
+// C/C++ include files
#include <vector>
/// Namespace for the AIDA detector description toolkit
diff --git a/DDCore/include/DD4hep/Fields.h b/DDCore/include/DD4hep/Fields.h
index 0a0d505c7..e001fed90 100644
--- a/DDCore/include/DD4hep/Fields.h
+++ b/DDCore/include/DD4hep/Fields.h
@@ -14,8 +14,8 @@
#define DD4HEP_FIELDS_H
// Framework include files
-#include "DD4hep/NamedObject.h"
-#include "DD4hep/Objects.h"
+#include <DD4hep/NamedObject.h>
+#include <DD4hep/Objects.h>
// C/C++ include files
#include <vector>
diff --git a/DDCore/include/DD4hep/GeoHandler.h b/DDCore/include/DD4hep/GeoHandler.h
index 976ecbd96..3674b4ea3 100644
--- a/DDCore/include/DD4hep/GeoHandler.h
+++ b/DDCore/include/DD4hep/GeoHandler.h
@@ -13,7 +13,10 @@
#ifndef DD4HEP_GEOHANDLER_H
#define DD4HEP_GEOHANDLER_H
-#include "DD4hep/Detector.h"
+/// Framework include files
+#include <DD4hep/Detector.h>
+
+/// C/C++ include files
#include <set>
#include <map>
#include <vector>
diff --git a/DDCore/include/DD4hep/GlobalAlignment.h b/DDCore/include/DD4hep/GlobalAlignment.h
index 41655bac1..ca369f94a 100644
--- a/DDCore/include/DD4hep/GlobalAlignment.h
+++ b/DDCore/include/DD4hep/GlobalAlignment.h
@@ -14,10 +14,10 @@
#define DD4HEP_GLOBALALIGNMENT_H
// Framework include files
-#include "DD4hep/Objects.h"
-#include "DD4hep/Volumes.h"
-#include "DD4hep/Alignments.h"
-#include "TGeoPhysicalNode.h"
+#include <DD4hep/Objects.h>
+#include <DD4hep/Volumes.h>
+#include <DD4hep/Alignments.h>
+#include <TGeoPhysicalNode.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/Grammar.h b/DDCore/include/DD4hep/Grammar.h
index f60bae044..616c167d8 100644
--- a/DDCore/include/DD4hep/Grammar.h
+++ b/DDCore/include/DD4hep/Grammar.h
@@ -22,8 +22,8 @@
#define DD4HEP_GRAMMAR_H
// Framework include files
-#include "DD4hep/config.h"
-#include "DD4hep/Primitives.h"
+#include <DD4hep/config.h>
+#include <DD4hep/Primitives.h>
// C/C++ include files
#include <string>
diff --git a/DDCore/include/DD4hep/GrammarUnparsed.h b/DDCore/include/DD4hep/GrammarUnparsed.h
index aa0a53362..20d89dd4b 100644
--- a/DDCore/include/DD4hep/GrammarUnparsed.h
+++ b/DDCore/include/DD4hep/GrammarUnparsed.h
@@ -26,7 +26,7 @@
#endif
// Framework include files
-#include "DD4hep/Grammar.h"
+#include <DD4hep/Grammar.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/GridPhiEta.h b/DDCore/include/DD4hep/GridPhiEta.h
index 67dab0f7b..054301da2 100644
--- a/DDCore/include/DD4hep/GridPhiEta.h
+++ b/DDCore/include/DD4hep/GridPhiEta.h
@@ -16,8 +16,8 @@
#define DD4HEP_GRIDPHIETA_H 1
// Framework includes
-#include "DDSegmentation/GridPhiEta.h"
-#include "DD4hep/Segmentations.h"
+#include <DDSegmentation/GridPhiEta.h>
+#include <DD4hep/Segmentations.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/GridRPhiEta.h b/DDCore/include/DD4hep/GridRPhiEta.h
index c081bec79..cbcc5b3b3 100644
--- a/DDCore/include/DD4hep/GridRPhiEta.h
+++ b/DDCore/include/DD4hep/GridRPhiEta.h
@@ -16,8 +16,8 @@
#define DD4HEP_GRIDRPHIETA_H 1
// Framework includes
-#include "DD4hep/Segmentations.h"
-#include "DDSegmentation/GridRPhiEta.h"
+#include <DD4hep/Segmentations.h>
+#include <DDSegmentation/GridRPhiEta.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/Handle.h b/DDCore/include/DD4hep/Handle.h
index 8dfdbce70..ed3791103 100644
--- a/DDCore/include/DD4hep/Handle.h
+++ b/DDCore/include/DD4hep/Handle.h
@@ -14,7 +14,7 @@
#define DD4HEP_HANDLE_H
// Framework include files
-#include "DD4hep/Primitives.h"
+#include <DD4hep/Primitives.h>
#include <string>
#include <typeinfo>
diff --git a/DDCore/include/DD4hep/IDDescriptor.h b/DDCore/include/DD4hep/IDDescriptor.h
index 2e33c80c1..68211da54 100644
--- a/DDCore/include/DD4hep/IDDescriptor.h
+++ b/DDCore/include/DD4hep/IDDescriptor.h
@@ -14,8 +14,8 @@
#define DD4HEP_IDDESCRIPTOR_H
// Framework include files
-#include "DD4hep/Handle.h"
-#include "DD4hep/BitFieldCoder.h"
+#include <DD4hep/Handle.h>
+#include <DD4hep/BitFieldCoder.h>
// C++ include files
#include <string>
diff --git a/DDCore/include/DD4hep/MatrixHelpers.h b/DDCore/include/DD4hep/MatrixHelpers.h
index 71282fb39..49748809f 100644
--- a/DDCore/include/DD4hep/MatrixHelpers.h
+++ b/DDCore/include/DD4hep/MatrixHelpers.h
@@ -14,7 +14,7 @@
#define DD4HEP_MATRIXHELPERS_H
// Framework include files
-#include "DD4hep/Objects.h"
+#include <DD4hep/Objects.h>
// Forward declarations
class TGeoTranslation;
diff --git a/DDCore/include/DD4hep/Memory.h b/DDCore/include/DD4hep/Memory.h
index f8ac6671f..275c7cb77 100644
--- a/DDCore/include/DD4hep/Memory.h
+++ b/DDCore/include/DD4hep/Memory.h
@@ -15,7 +15,7 @@
#define DD4HEP_MEMORY_H
// Framework include files
-#include "RVersion.h"
+#include <RVersion.h>
#ifdef __GNUC__
#pragma GCC diagnostic push
diff --git a/DDCore/include/DD4hep/MultiSegmentation.h b/DDCore/include/DD4hep/MultiSegmentation.h
index f562a7cc4..92bb6fb91 100644
--- a/DDCore/include/DD4hep/MultiSegmentation.h
+++ b/DDCore/include/DD4hep/MultiSegmentation.h
@@ -16,8 +16,8 @@
#define DD4HEP_MULTISEGMENTATION_H 1
// Framework include files
-#include "DD4hep/Segmentations.h"
-#include "DDSegmentation/MultiSegmentation.h"
+#include <DD4hep/Segmentations.h>
+#include <DDSegmentation/MultiSegmentation.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/NoSegmentation.h b/DDCore/include/DD4hep/NoSegmentation.h
index 54cb8f6a7..50802e0db 100644
--- a/DDCore/include/DD4hep/NoSegmentation.h
+++ b/DDCore/include/DD4hep/NoSegmentation.h
@@ -16,7 +16,7 @@
#define DD4HEP_NOSEGMENTATION_H 1
// Framework include files
-#include "DD4hep/Segmentations.h"
+#include <DD4hep/Segmentations.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/ObjectExtensions.h b/DDCore/include/DD4hep/ObjectExtensions.h
index 70b54a19e..2042c1066 100644
--- a/DDCore/include/DD4hep/ObjectExtensions.h
+++ b/DDCore/include/DD4hep/ObjectExtensions.h
@@ -14,7 +14,7 @@
#define DD4HEP_OBJECTEXTENSIONS_H
// Framework include files
-#include "DD4hep/ExtensionEntry.h"
+#include <DD4hep/ExtensionEntry.h>
// C/C++ include files
#include <map>
diff --git a/DDCore/include/DD4hep/OpaqueData.h b/DDCore/include/DD4hep/OpaqueData.h
index ad19ca0a9..b386b513a 100644
--- a/DDCore/include/DD4hep/OpaqueData.h
+++ b/DDCore/include/DD4hep/OpaqueData.h
@@ -14,7 +14,7 @@
#define DD4HEP_OPAQUEDATA_H
// Framework include files
-#include "DD4hep/Grammar.h"
+#include <DD4hep/Grammar.h>
// C/C++ include files
#include <typeinfo>
diff --git a/DDCore/include/DD4hep/OpaqueDataBinder.h b/DDCore/include/DD4hep/OpaqueDataBinder.h
index 8a647ead6..3ed052fc6 100644
--- a/DDCore/include/DD4hep/OpaqueDataBinder.h
+++ b/DDCore/include/DD4hep/OpaqueDataBinder.h
@@ -14,7 +14,7 @@
#define DD4HEP_OPAQUEDATABINDER_H
// Framework include files
-#include "DD4hep/Printout.h"
+#include <DD4hep/Printout.h>
// C/C++ include files
#include <string>
diff --git a/DDCore/include/DD4hep/PolarGridRPhi.h b/DDCore/include/DD4hep/PolarGridRPhi.h
index addc7ab99..7a2a519e8 100644
--- a/DDCore/include/DD4hep/PolarGridRPhi.h
+++ b/DDCore/include/DD4hep/PolarGridRPhi.h
@@ -16,7 +16,7 @@
#define DD4HEP_POLARGRIDRPHI_H 1
// Framework include files
-#include "DD4hep/Segmentations.h"
+#include <DD4hep/Segmentations.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/PolarGridRPhi2.h b/DDCore/include/DD4hep/PolarGridRPhi2.h
index 9b29bdbd5..e14cc99ba 100644
--- a/DDCore/include/DD4hep/PolarGridRPhi2.h
+++ b/DDCore/include/DD4hep/PolarGridRPhi2.h
@@ -16,7 +16,7 @@
#define DD4HEP_POLARGRIDRPHI2_H 1
// Framework include files
-#include "DD4hep/Segmentations.h"
+#include <DD4hep/Segmentations.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/Primitives.h b/DDCore/include/DD4hep/Primitives.h
index beb50ec13..6706f549d 100644
--- a/DDCore/include/DD4hep/Primitives.h
+++ b/DDCore/include/DD4hep/Primitives.h
@@ -17,7 +17,7 @@
// Forward declaring header for package configuration
-#include "DD4hep/config.h"
-#include "Parsers/Primitives.h"
+#include <DD4hep/config.h>
+#include <Parsers/Primitives.h>
#endif // DD4HEP_PRIMITIVES_H
diff --git a/DDCore/include/DD4hep/Printout.h b/DDCore/include/DD4hep/Printout.h
index 2aabd71e9..6c32b827b 100644
--- a/DDCore/include/DD4hep/Printout.h
+++ b/DDCore/include/DD4hep/Printout.h
@@ -17,7 +17,7 @@
// Forward declaring header for package configuration
-#include "DD4hep/config.h"
-#include "Parsers/Printout.h"
+#include <DD4hep/config.h>
+#include <Parsers/Printout.h>
#endif // DD4HEP_PRINTOUT_H
diff --git a/DDCore/include/DD4hep/Readout.h b/DDCore/include/DD4hep/Readout.h
index 75030fc08..5595bcf9e 100644
--- a/DDCore/include/DD4hep/Readout.h
+++ b/DDCore/include/DD4hep/Readout.h
@@ -14,9 +14,9 @@
#define DD4HEP_READOUT_H
// Framework include files
-#include "DD4hep/Handle.h"
-#include "DD4hep/IDDescriptor.h"
-#include "DD4hep/Segmentations.h"
+#include <DD4hep/Handle.h>
+#include <DD4hep/IDDescriptor.h>
+#include <DD4hep/Segmentations.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/SurfaceInstaller.h b/DDCore/include/DD4hep/SurfaceInstaller.h
index 39ec553e3..f2d9c53c7 100644
--- a/DDCore/include/DD4hep/SurfaceInstaller.h
+++ b/DDCore/include/DD4hep/SurfaceInstaller.h
@@ -14,9 +14,9 @@
#define DD4HEP_SURFACEINSTALLER_H 1
// Framework include files
-#include "DD4hep/Detector.h"
-#include "DD4hep/DetectorTools.h"
-#include "DD4hep/DetFactoryHelper.h"
+#include <DD4hep/Detector.h>
+#include <DD4hep/DetectorTools.h>
+#include <DD4hep/DetFactoryHelper.h>
// C/C++ include files
#include <map>
@@ -116,8 +116,8 @@ namespace dd4hep {
#if defined(DD4HEP_USE_SURFACEINSTALL_HELPER)
-#include "DDRec/Surface.h"
-#include "DDRec/DetectorData.h"
+#include <DDRec/Surface.h>
+#include <DDRec/DetectorData.h>
#ifndef SURFACEINSTALLER_DATA
typedef void* SURFACEINSTALLER_DATA;
diff --git a/DDCore/include/DD4hep/TGeoUnits.h b/DDCore/include/DD4hep/TGeoUnits.h
deleted file mode 100644
index e11e79f67..000000000
--- a/DDCore/include/DD4hep/TGeoUnits.h
+++ /dev/null
@@ -1,20 +0,0 @@
-// OSOLETE
-// use dd4hepUnits and dd4hep:: instead
-
-#ifndef DD4HEP_TGEOUNITS_H
-#define DD4HEP_TGEOUNITS_H
-
-
-// Uncomment for backward compatibility
-//#define USE_TGEOUNITS_H
-
-#ifdef USE_TGEOUNITS_H
-#include "DD4hepUnits.h"
-
-namesapce tgeo{
- using dd4hep ;
-}
-
-#endif
-
-#endif // DD4HEP_TGEOUNITS_H
diff --git a/DDCore/include/DD4hep/VolumeProcessor.h b/DDCore/include/DD4hep/VolumeProcessor.h
index 73901a18d..ade06eeaa 100644
--- a/DDCore/include/DD4hep/VolumeProcessor.h
+++ b/DDCore/include/DD4hep/VolumeProcessor.h
@@ -14,8 +14,8 @@
#define DD4HEP_VOLUMEPROCESSOR_H
// Framework includes
-#include "DD4hep/DetElement.h"
-#include "DD4hep/Volumes.h"
+#include <DD4hep/DetElement.h>
+#include <DD4hep/Volumes.h>
// C/C++ include files
#include <memory>
diff --git a/DDCore/include/DD4hep/WaferGridXY.h b/DDCore/include/DD4hep/WaferGridXY.h
index 38ad1930b..593f4c0e7 100644
--- a/DDCore/include/DD4hep/WaferGridXY.h
+++ b/DDCore/include/DD4hep/WaferGridXY.h
@@ -16,7 +16,7 @@
#define DD4HEP_WAFERGRIDXY_H 1
// Framework include files
-#include "DD4hep/Segmentations.h"
+#include <DD4hep/Segmentations.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/World.h b/DDCore/include/DD4hep/World.h
index f73ceae5b..13e4ad3d6 100644
--- a/DDCore/include/DD4hep/World.h
+++ b/DDCore/include/DD4hep/World.h
@@ -14,7 +14,7 @@
#define DD4HEP_WORLD_H
// Framework include files
-#include "DD4hep/DetElement.h"
+#include <DD4hep/DetElement.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DD4hep/detail/Handle.inl b/DDCore/include/DD4hep/detail/Handle.inl
index 13beb9370..5c965408b 100644
--- a/DDCore/include/DD4hep/detail/Handle.inl
+++ b/DDCore/include/DD4hep/detail/Handle.inl
@@ -12,7 +12,7 @@
//==========================================================================
// Framework include files
-#include "DD4hep/Handle.h"
+#include <DD4hep/Handle.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DDSegmentation/BitField64.h b/DDCore/include/DDSegmentation/BitField64.h
index 4b2895a54..7db377c31 100644
--- a/DDCore/include/DDSegmentation/BitField64.h
+++ b/DDCore/include/DDSegmentation/BitField64.h
@@ -19,7 +19,7 @@
#include <map>
#include <sstream>
-#include "DDSegmentation/BitFieldCoder.h"
+#include <DDSegmentation/BitFieldCoder.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/DDSegmentation/CartesianGrid.h b/DDCore/include/DDSegmentation/CartesianGrid.h
index be3d98c8d..1a6b14c1c 100644
--- a/DDCore/include/DDSegmentation/CartesianGrid.h
+++ b/DDCore/include/DDSegmentation/CartesianGrid.h
@@ -19,7 +19,7 @@
#ifndef DDSEGMENTATION_CARTESIANGRID_H
#define DDSEGMENTATION_CARTESIANGRID_H
-#include "DDSegmentation/Segmentation.h"
+#include <DDSegmentation/Segmentation.h>
namespace dd4hep {
namespace DDSegmentation {
diff --git a/DDCore/include/DDSegmentation/CartesianGridXY.h b/DDCore/include/DDSegmentation/CartesianGridXY.h
index 28fef9718..2ae5dcb56 100644
--- a/DDCore/include/DDSegmentation/CartesianGridXY.h
+++ b/DDCore/include/DDSegmentation/CartesianGridXY.h
@@ -8,10 +8,6 @@
// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
//
//==========================================================================
-
-
-
-
/*
* CartesianGridXY.h
*
@@ -22,7 +18,7 @@
#ifndef DDSEGMENTATION_CARTESIANGRIDXY_H
#define DDSEGMENTATION_CARTESIANGRIDXY_H
-#include "DDSegmentation/CartesianGrid.h"
+#include <DDSegmentation/CartesianGrid.h>
namespace dd4hep {
namespace DDSegmentation {
diff --git a/DDCore/include/DDSegmentation/CartesianGridXYStaggered.h b/DDCore/include/DDSegmentation/CartesianGridXYStaggered.h
index 441026adf..381f4bbe6 100644
--- a/DDCore/include/DDSegmentation/CartesianGridXYStaggered.h
+++ b/DDCore/include/DDSegmentation/CartesianGridXYStaggered.h
@@ -8,10 +8,6 @@
// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
//
//==========================================================================
-
-
-
-
/*
* CartesianGridXYStaggered.h
*
@@ -22,7 +18,7 @@
#ifndef DDSEGMENTATION_CARTESIANGRIDXYSTAGGERED_H
#define DDSEGMENTATION_CARTESIANGRIDXYSTAGGERED_H
-#include "DDSegmentation/CartesianGrid.h"
+#include <DDSegmentation/CartesianGrid.h>
namespace dd4hep {
namespace DDSegmentation {
diff --git a/DDCore/include/DDSegmentation/CartesianGridXYZ.h b/DDCore/include/DDSegmentation/CartesianGridXYZ.h
index 61b101ce3..644dbdaa0 100644
--- a/DDCore/include/DDSegmentation/CartesianGridXYZ.h
+++ b/DDCore/include/DDSegmentation/CartesianGridXYZ.h
@@ -8,7 +8,6 @@
// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
//
//==========================================================================
-
/*
* CartesianGridXYZ.h
*
@@ -19,7 +18,7 @@
#ifndef DDSEGMENTATION_CARTESIANGRIDXYZ_H
#define DDSEGMENTATION_CARTESIANGRIDXYZ_H
-#include "DDSegmentation/CartesianGridXY.h"
+#include <DDSegmentation/CartesianGridXY.h>
namespace dd4hep {
namespace DDSegmentation {
diff --git a/DDCore/include/DDSegmentation/CartesianGridXZ.h b/DDCore/include/DDSegmentation/CartesianGridXZ.h
index b4dcc77ca..3e358488e 100644
--- a/DDCore/include/DDSegmentation/CartesianGridXZ.h
+++ b/DDCore/include/DDSegmentation/CartesianGridXZ.h
@@ -8,7 +8,6 @@
// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
//
//==========================================================================
-
/*
* CartesianGridXY.h
*
@@ -19,7 +18,7 @@
#ifndef DDSEGMENTATION_CARTESIANGRIDXZ_H
#define DDSEGMENTATION_CARTESIANGRIDXZ_H
-#include "DDSegmentation/CartesianGrid.h"
+#include <DDSegmentation/CartesianGrid.h>
namespace dd4hep {
namespace DDSegmentation {
diff --git a/DDCore/include/DDSegmentation/CartesianGridYZ.h b/DDCore/include/DDSegmentation/CartesianGridYZ.h
index 39930febf..50a4475d4 100644
--- a/DDCore/include/DDSegmentation/CartesianGridYZ.h
+++ b/DDCore/include/DDSegmentation/CartesianGridYZ.h
@@ -11,7 +11,7 @@
#ifndef DDSEGMENTATION_CARTESIANGRIDYZ_H
#define DDSEGMENTATION_CARTESIANGRIDYZ_H
-#include "DDSegmentation/CartesianGrid.h"
+#include <DDSegmentation/CartesianGrid.h>
namespace dd4hep {
namespace DDSegmentation {
diff --git a/DDCore/include/DDSegmentation/CartesianStrip.h b/DDCore/include/DDSegmentation/CartesianStrip.h
index 709345fa3..8c42f5e5b 100644
--- a/DDCore/include/DDSegmentation/CartesianStrip.h
+++ b/DDCore/include/DDSegmentation/CartesianStrip.h
@@ -8,7 +8,6 @@
// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
//
//==========================================================================
-
/*
* CartesianStrip.h
*
@@ -20,7 +19,7 @@
#ifndef DDSEGMENTATION_CARTESIANSTRIP_H
#define DDSEGMENTATION_CARTESIANSTRIP_H
-#include "DDSegmentation/Segmentation.h"
+#include <DDSegmentation/Segmentation.h>
namespace dd4hep {
namespace DDSegmentation {
diff --git a/DDCore/include/DDSegmentation/CartesianStripX.h b/DDCore/include/DDSegmentation/CartesianStripX.h
index e5b4c46dc..a2d867bb1 100644
--- a/DDCore/include/DDSegmentation/CartesianStripX.h
+++ b/DDCore/include/DDSegmentation/CartesianStripX.h
@@ -20,7 +20,7 @@
#ifndef DDSEGMENTATION_CARTESIANSTRIPX_H
#define DDSEGMENTATION_CARTESIANSTRIPX_H
-#include "DDSegmentation/CartesianStrip.h"
+#include <DDSegmentation/CartesianStrip.h>
namespace dd4hep {
namespace DDSegmentation {
diff --git a/DDCore/include/DDSegmentation/CartesianStripY.h b/DDCore/include/DDSegmentation/CartesianStripY.h
index b452f6b10..7bfff98e2 100644
--- a/DDCore/include/DDSegmentation/CartesianStripY.h
+++ b/DDCore/include/DDSegmentation/CartesianStripY.h
@@ -8,7 +8,6 @@
// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
//
//==========================================================================
-
/*
* CartesianStripY.h
*
@@ -20,7 +19,7 @@
#ifndef DDSEGMENTATION_CARTESIANSTRIPY_H
#define DDSEGMENTATION_CARTESIANSTRIPY_H
-#include "DDSegmentation/CartesianStrip.h"
+#include <DDSegmentation/CartesianStrip.h>
namespace dd4hep {
namespace DDSegmentation {
diff --git a/DDCore/include/DDSegmentation/CartesianStripZ.h b/DDCore/include/DDSegmentation/CartesianStripZ.h
index a7603ab11..ce03e9a70 100644
--- a/DDCore/include/DDSegmentation/CartesianStripZ.h
+++ b/DDCore/include/DDSegmentation/CartesianStripZ.h
@@ -20,7 +20,7 @@
#ifndef DDSEGMENTATION_CARTESIANSTRIPZ_H
#define DDSEGMENTATION_CARTESIANSTRIPZ_H
-#include "DDSegmentation/CartesianStrip.h"
+#include <DDSegmentation/CartesianStrip.h>
namespace dd4hep {
namespace DDSegmentation {
diff --git a/DDCore/include/DDSegmentation/CylindricalSegmentation.h b/DDCore/include/DDSegmentation/CylindricalSegmentation.h
index e7b92dd40..84ce8e7a5 100644
--- a/DDCore/include/DDSegmentation/CylindricalSegmentation.h
+++ b/DDCore/include/DDSegmentation/CylindricalSegmentation.h
@@ -19,7 +19,7 @@
#ifndef DDSEGMENTATION_CYLINDRICALSEGMENTATION_H
#define DDSEGMENTATION_CYLINDRICALSEGMENTATION_H
-#include "DDSegmentation/Segmentation.h"
+#include <DDSegmentation/Segmentation.h>
#include <map>
diff --git a/DDCore/include/DDSegmentation/GridPhiEta.h b/DDCore/include/DDSegmentation/GridPhiEta.h
index 76a8bc099..a45b9db5b 100644
--- a/DDCore/include/DDSegmentation/GridPhiEta.h
+++ b/DDCore/include/DDSegmentation/GridPhiEta.h
@@ -12,9 +12,8 @@
#ifndef DDSEGMENTATION_GRIDPHIETA_H
#define DDSEGMENTATION_GRIDPHIETA_H
-#include "DDSegmentation/Segmentation.h"
+#include <DDSegmentation/Segmentation.h>
-/* #include "DDSegmentation/SegmentationUtil.h" */
#include <cmath>
/** GridPhiEta DDSegmentation/include/DDSegmentation/GridPhiEta.h GridPhiEta.h
diff --git a/DDCore/include/DDSegmentation/GridRPhiEta.h b/DDCore/include/DDSegmentation/GridRPhiEta.h
index ec65b4895..0a548c436 100644
--- a/DDCore/include/DDSegmentation/GridRPhiEta.h
+++ b/DDCore/include/DDSegmentation/GridRPhiEta.h
@@ -13,7 +13,7 @@
#define DDSEGMENTATION_GRIDRPHIETA_H
// Framework includes
-#include "DDSegmentation/GridPhiEta.h"
+#include <DDSegmentation/GridPhiEta.h>
/** GridRPhiEta DDSegmentation/include/DDSegmentation/GridRPhiEta.h GridRPhiEta.h
*
diff --git a/DDCore/include/DDSegmentation/HexGrid.h b/DDCore/include/DDSegmentation/HexGrid.h
index 434177790..638db1abb 100644
--- a/DDCore/include/DDSegmentation/HexGrid.h
+++ b/DDCore/include/DDSegmentation/HexGrid.h
@@ -19,7 +19,7 @@
#ifndef DDSEGMENTATION_HEXGRID_H
#define DDSEGMENTATION_HEXGRID_H
-#include "DDSegmentation/Segmentation.h"
+#include <DDSegmentation/Segmentation.h>
namespace dd4hep {
namespace DDSegmentation {
diff --git a/DDCore/include/DDSegmentation/MegatileLayerGridXY.h b/DDCore/include/DDSegmentation/MegatileLayerGridXY.h
index 743365b3c..ea4b3223e 100644
--- a/DDCore/include/DDSegmentation/MegatileLayerGridXY.h
+++ b/DDCore/include/DDSegmentation/MegatileLayerGridXY.h
@@ -19,7 +19,7 @@
#ifndef DDSEGMENTATION_MEGATILELAYERGRIDXY_H
#define DDSEGMENTATION_MEGATILELAYERGRIDXY_H
-#include "DDSegmentation/CartesianGrid.h"
+#include <DDSegmentation/CartesianGrid.h>
#include <cassert>
diff --git a/DDCore/include/DDSegmentation/MultiSegmentation.h b/DDCore/include/DDSegmentation/MultiSegmentation.h
index cff283d19..e4a92e848 100644
--- a/DDCore/include/DDSegmentation/MultiSegmentation.h
+++ b/DDCore/include/DDSegmentation/MultiSegmentation.h
@@ -1,4 +1,3 @@
-// $Id$
//==========================================================================
// AIDA Detector description implementation
//--------------------------------------------------------------------------
@@ -14,7 +13,7 @@
#ifndef DDSEGMENTATION_MULTISEGMENTATION_H
#define DDSEGMENTATION_MULTISEGMENTATION_H
-#include "DDSegmentation/Segmentation.h"
+#include <DDSegmentation/Segmentation.h>
/// Main handle class to hold a TGeo alignment object of type TGeoPhysicalNode
namespace dd4hep {
diff --git a/DDCore/include/DDSegmentation/NoSegmentation.h b/DDCore/include/DDSegmentation/NoSegmentation.h
index 5e15b2442..0da938670 100644
--- a/DDCore/include/DDSegmentation/NoSegmentation.h
+++ b/DDCore/include/DDSegmentation/NoSegmentation.h
@@ -19,7 +19,7 @@
#ifndef DDSEGMENTATION_NOSEGMENTATION_H
#define DDSEGMENTATION_NOSEGMENTATION_H
-#include "DDSegmentation/Segmentation.h"
+#include <DDSegmentation/Segmentation.h>
namespace dd4hep {
namespace DDSegmentation {
diff --git a/DDCore/include/DDSegmentation/PolarGrid.h b/DDCore/include/DDSegmentation/PolarGrid.h
index 20c4bdbc4..8bf5fe36f 100644
--- a/DDCore/include/DDSegmentation/PolarGrid.h
+++ b/DDCore/include/DDSegmentation/PolarGrid.h
@@ -19,7 +19,7 @@
#ifndef DDSEGMENTATION_POLARGRID_H
#define DDSEGMENTATION_POLARGRID_H
-#include "DDSegmentation/Segmentation.h"
+#include <DDSegmentation/Segmentation.h>
namespace dd4hep {
namespace DDSegmentation {
diff --git a/DDCore/include/DDSegmentation/PolarGridRPhi.h b/DDCore/include/DDSegmentation/PolarGridRPhi.h
index 4aa85263a..2895b0c71 100644
--- a/DDCore/include/DDSegmentation/PolarGridRPhi.h
+++ b/DDCore/include/DDSegmentation/PolarGridRPhi.h
@@ -19,7 +19,7 @@
#ifndef DDSEGMENTATION_POLARGRIDRPHI_H
#define DDSEGMENTATION_POLARGRIDRPHI_H
-#include "DDSegmentation/PolarGrid.h"
+#include <DDSegmentation/PolarGrid.h>
#include <math.h>
namespace dd4hep {
diff --git a/DDCore/include/DDSegmentation/PolarGridRPhi2.h b/DDCore/include/DDSegmentation/PolarGridRPhi2.h
index 2d24d0bc4..0e859027c 100644
--- a/DDCore/include/DDSegmentation/PolarGridRPhi2.h
+++ b/DDCore/include/DDSegmentation/PolarGridRPhi2.h
@@ -19,7 +19,7 @@
#ifndef DDSEGMENTATION_POLARGRIDRPHI2_H
#define DDSEGMENTATION_POLARGRIDRPHI2_H
-#include "DDSegmentation/PolarGrid.h"
+#include <DDSegmentation/PolarGrid.h>
#include <cmath>
#include <vector>
diff --git a/DDCore/include/DDSegmentation/ProjectiveCylinder.h b/DDCore/include/DDSegmentation/ProjectiveCylinder.h
index cf57f064e..eca70c13c 100644
--- a/DDCore/include/DDSegmentation/ProjectiveCylinder.h
+++ b/DDCore/include/DDSegmentation/ProjectiveCylinder.h
@@ -19,7 +19,7 @@
#ifndef DDSEGMENTATION_PROJECTIVECYLINDER_H
#define DDSEGMENTATION_PROJECTIVECYLINDER_H
-#include "CylindricalSegmentation.h"
+#include <DDSegmentation/CylindricalSegmentation.h>
namespace dd4hep {
namespace DDSegmentation {
diff --git a/DDCore/include/DDSegmentation/Segmentation.h b/DDCore/include/DDSegmentation/Segmentation.h
index 2a6c26849..b2da572ba 100644
--- a/DDCore/include/DDSegmentation/Segmentation.h
+++ b/DDCore/include/DDSegmentation/Segmentation.h
@@ -19,9 +19,9 @@
#ifndef DDSEGMENTATION_SEGMENTATION_H
#define DDSEGMENTATION_SEGMENTATION_H
-#include "DD4hep/detail/SegmentationsInterna.h"
-#include "DDSegmentation/BitFieldCoder.h"
-#include "DDSegmentation/SegmentationParameter.h"
+#include <DD4hep/detail/SegmentationsInterna.h>
+#include <DDSegmentation/BitFieldCoder.h>
+#include <DDSegmentation/SegmentationParameter.h>
#include <map>
#include <utility>
diff --git a/DDCore/include/DDSegmentation/SegmentationParameter.h b/DDCore/include/DDSegmentation/SegmentationParameter.h
index 8a20bc72c..894973b50 100644
--- a/DDCore/include/DDSegmentation/SegmentationParameter.h
+++ b/DDCore/include/DDSegmentation/SegmentationParameter.h
@@ -8,7 +8,6 @@
// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
//
//==========================================================================
-
/*
* SegmentationParameter.h
*
diff --git a/DDCore/include/DDSegmentation/SegmentationUtil.h b/DDCore/include/DDSegmentation/SegmentationUtil.h
index 875fdfd86..b450e363b 100644
--- a/DDCore/include/DDSegmentation/SegmentationUtil.h
+++ b/DDCore/include/DDSegmentation/SegmentationUtil.h
@@ -1,3 +1,13 @@
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
/*
* SegmentationUtil.h
*
@@ -8,7 +18,7 @@
#ifndef DDSEGMENTATION_SEGMENTATIONUTIL_H
#define DDSEGMENTATION_SEGMENTATIONUTIL_H
-#include "DDSegmentation/Segmentation.h"
+#include <DDSegmentation/Segmentation.h>
#include <cmath>
#include <vector>
diff --git a/DDCore/include/DDSegmentation/TiledLayerGridXY.h b/DDCore/include/DDSegmentation/TiledLayerGridXY.h
index 20e2551b6..c36fa176f 100644
--- a/DDCore/include/DDSegmentation/TiledLayerGridXY.h
+++ b/DDCore/include/DDSegmentation/TiledLayerGridXY.h
@@ -19,7 +19,7 @@
#ifndef DDSEGMENTATION_TILEDLAYERGRIDXY_H
#define DDSEGMENTATION_TILEDLAYERGRIDXY_H
-#include "DDSegmentation/CartesianGrid.h"
+#include <DDSegmentation/CartesianGrid.h>
// C/C++ includes
#include <string>
diff --git a/DDCore/include/DDSegmentation/TiledLayerSegmentation.h b/DDCore/include/DDSegmentation/TiledLayerSegmentation.h
index d45790dd4..ac13e5049 100644
--- a/DDCore/include/DDSegmentation/TiledLayerSegmentation.h
+++ b/DDCore/include/DDSegmentation/TiledLayerSegmentation.h
@@ -19,7 +19,7 @@
#ifndef DDSEGMENTATION_TILEDLAYERSEGMENTATION_H
#define DDSEGMENTATION_TILEDLAYERSEGMENTATION_H
-#include "DDSegmentation/Segmentation.h"
+#include <DDSegmentation/Segmentation.h>
// C/C++ includes
#include <string>
diff --git a/DDCore/include/DDSegmentation/WaferGridXY.h b/DDCore/include/DDSegmentation/WaferGridXY.h
index 57a84f7f6..706ad1dde 100644
--- a/DDCore/include/DDSegmentation/WaferGridXY.h
+++ b/DDCore/include/DDSegmentation/WaferGridXY.h
@@ -19,7 +19,7 @@
#ifndef DDSEGMENTATION_WAFERGRIDXY_H
#define DDSEGMENTATION_WAFERGRIDXY_H
-#include "DDSegmentation/CartesianGrid.h"
+#include <DDSegmentation/CartesianGrid.h>
#define MAX_GROUPS 100
#define MAX_WAFERS 100
diff --git a/DDCore/include/JSON/ChildValue.h b/DDCore/include/JSON/ChildValue.h
index 305d4d4ed..a2c256863 100644
--- a/DDCore/include/JSON/ChildValue.h
+++ b/DDCore/include/JSON/ChildValue.h
@@ -14,10 +14,10 @@
#define JSON_CHILDVALUE_H
// Framework include files
-#include "JSON/Dimension.h"
+#include <JSON/Dimension.h>
#define DD4HEP_DIMENSION_NS json
-#include "Parsers/detail/ChildValue.h"
+#include <Parsers/detail/ChildValue.h>
#undef DD4HEP_DIMENSION_NS
diff --git a/DDCore/include/JSON/ChildValue.inl b/DDCore/include/JSON/ChildValue.inl
index aa3785e3b..1c9d9b5bd 100644
--- a/DDCore/include/JSON/ChildValue.inl
+++ b/DDCore/include/JSON/ChildValue.inl
@@ -14,10 +14,10 @@
#define DD4HEP_JSONCHILDVALUE_INL
// Framework include files
-#include "JSON/ChildValue.h"
+#include <JSON/ChildValue.h>
#define DD4HEP_DIMENSION_NS json
-#include "Parsers/detail/ChildValue.inl"
+#include <Parsers/detail/ChildValue.inl>
#undef DD4HEP_DIMENSION_NS
#endif /* DD4HEP_JSONCHILDVALUE_INL */
diff --git a/DDCore/include/JSON/Conversions.h b/DDCore/include/JSON/Conversions.h
index 691a1452b..554a44b6a 100644
--- a/DDCore/include/JSON/Conversions.h
+++ b/DDCore/include/JSON/Conversions.h
@@ -14,7 +14,7 @@
#define JSON_CONVERSIONS_H
#define DD4HEP_CONVERSION_NS json
-#include "Parsers/detail/Conversions.h"
+#include <Parsers/detail/Conversions.h>
#undef DD4HEP_CONVERSION_NS
#endif // JSON_CONVERSIONS_H
diff --git a/DDCore/include/JSON/Detector.h b/DDCore/include/JSON/Detector.h
index 91a34c3f8..4b46099f3 100644
--- a/DDCore/include/JSON/Detector.h
+++ b/DDCore/include/JSON/Detector.h
@@ -14,11 +14,11 @@
#define JSON_DETECTOR_H
// Framework include files
-#include "JSON/Dimension.h"
+#include <JSON/Dimension.h>
/// Include the implementation in the proper namespace
#define DD4HEP_DIMENSION_NS json
-#include "Parsers/detail/Detector.h"
+#include <Parsers/detail/Detector.h>
#undef DD4HEP_DIMENSION_NS
#endif // JSON_DETECTOR_H
diff --git a/DDCore/include/JSON/Dimension.h b/DDCore/include/JSON/Dimension.h
index 1607f2d80..c596b49d9 100644
--- a/DDCore/include/JSON/Dimension.h
+++ b/DDCore/include/JSON/Dimension.h
@@ -14,11 +14,11 @@
#define JSON_DIMENSION_H
// Framework include files
-#include "JSON/Elements.h"
-#include "JSON/Tags.h"
+#include <JSON/Elements.h>
+#include <JSON/Tags.h>
#define DD4HEP_DIMENSION_NS json
-#include "Parsers/detail/Dimension.h"
+#include <Parsers/detail/Dimension.h>
#undef DD4HEP_DIMENSION_NS
#endif // JSON_DIMENSION_H
diff --git a/DDCore/include/JSON/Dimension.inl b/DDCore/include/JSON/Dimension.inl
index 2380b8ac5..4f265af79 100644
--- a/DDCore/include/JSON/Dimension.inl
+++ b/DDCore/include/JSON/Dimension.inl
@@ -14,10 +14,10 @@
#define DD4HEP_JSONDIMENSION_INL
// Framework include files
-#include "JSON/Dimension.h"
+#include <JSON/Dimension.h>
#define DD4HEP_DIMENSION_NS json
-#include "Parsers/detail/Dimension.inl"
+#include <Parsers/detail/Dimension.inl>
#undef DD4HEP_DIMENSION_NS
#endif /* DD4HEP_JSONDIMENSION_INL */
diff --git a/DDCore/include/JSON/Helper.h b/DDCore/include/JSON/Helper.h
index 838fcee7b..658d794b2 100644
--- a/DDCore/include/JSON/Helper.h
+++ b/DDCore/include/JSON/Helper.h
@@ -14,11 +14,11 @@
#define JSON_HELPER_H
// Framework include files
-#include "JSON/Detector.h"
-#include "JSON/ChildValue.h"
-#include "DD4hep/Detector.h"
-#include "DD4hep/Factories.h"
-#include "DD4hep/DD4hepUnits.h"
+#include <JSON/Detector.h>
+#include <JSON/ChildValue.h>
+#include <DD4hep/Detector.h>
+#include <DD4hep/Factories.h>
+#include <DD4hep/DD4hepUnits.h>
// Shortcuts to elements of the JSON namespace
typedef dd4hep::json::Attribute json_attr_t;
diff --git a/DDCore/include/JSON/Printout.h b/DDCore/include/JSON/Printout.h
index 3b61b1ebd..eee4a07ec 100644
--- a/DDCore/include/JSON/Printout.h
+++ b/DDCore/include/JSON/Printout.h
@@ -19,6 +19,6 @@
*
* See the externalized header in doc/externalize for details.
*/
-#include "Parsers/Printout.h"
+#include <Parsers/Printout.h>
#endif // JSON_PRINTOUT_H
diff --git a/DDCore/include/JSON/Tags.h b/DDCore/include/JSON/Tags.h
index 674b5cd8b..f8c0af8b1 100644
--- a/DDCore/include/JSON/Tags.h
+++ b/DDCore/include/JSON/Tags.h
@@ -16,7 +16,7 @@
#define DECLARE_UNICODE_TAG(x)
// Framework include files
-#include "JSON/Elements.h"
+#include <JSON/Elements.h>
// Helpers to access tags and attributes quickly without specifying explicitly namespaces
#define _dd4hep_Unicode_Item(a) #a
diff --git a/DDCore/include/JSON/config.h b/DDCore/include/JSON/config.h
index 1c5d179ef..c9dded18d 100644
--- a/DDCore/include/JSON/config.h
+++ b/DDCore/include/JSON/config.h
@@ -13,7 +13,7 @@
#ifndef JSON_CONFIG_H
#define JSON_CONFIG_H
-#include "Parsers/config.h"
+#include <Parsers/config.h>
#define DD4HEP_USE_BOOST_JSON 1
diff --git a/DDCore/include/Parsers/Exceptions.h b/DDCore/include/Parsers/Exceptions.h
index f1253db0e..360721365 100644
--- a/DDCore/include/Parsers/Exceptions.h
+++ b/DDCore/include/Parsers/Exceptions.h
@@ -14,7 +14,7 @@
#define PARSERS_EXCEPTIONS_H
// Framework include files
-#include "Parsers/config.h"
+#include <Parsers/config.h>
// C/C++ include files
#include <string>
diff --git a/DDCore/include/Parsers/Primitives.h b/DDCore/include/Parsers/Primitives.h
index 2d4ed0afd..8aa470a22 100644
--- a/DDCore/include/Parsers/Primitives.h
+++ b/DDCore/include/Parsers/Primitives.h
@@ -14,7 +14,7 @@
#define PARSERS_PRIMITIVES_H
// Framework include files
-#include "Parsers/config.h"
+#include <Parsers/config.h>
// C/C++ include files
#include <map>
diff --git a/DDCore/include/Parsers/Printout.h b/DDCore/include/Parsers/Printout.h
index c48acd14b..66a94028f 100644
--- a/DDCore/include/Parsers/Printout.h
+++ b/DDCore/include/Parsers/Printout.h
@@ -14,7 +14,7 @@
#define PARSERS_PRINTOUT_H
// Framework include files
-#include "Parsers/config.h"
+#include <Parsers/config.h>
// C/C++ include files
#include <cstdio>
diff --git a/DDCore/include/Parsers/detail/Detector.imp b/DDCore/include/Parsers/detail/Detector.imp
index 5242bb2dd..f8553c64d 100644
--- a/DDCore/include/Parsers/detail/Detector.imp
+++ b/DDCore/include/Parsers/detail/Detector.imp
@@ -21,8 +21,8 @@
// Framework include files
-#include "DD4hep/Plugins.h"
-#include "DD4hep/Detector.h"
+#include <DD4hep/Plugins.h>
+#include <DD4hep/Detector.h>
namespace detail { class Detector; }
diff --git a/DDCore/include/XML/Conversions.h b/DDCore/include/XML/Conversions.h
index 45d384b20..ca41bc4a3 100644
--- a/DDCore/include/XML/Conversions.h
+++ b/DDCore/include/XML/Conversions.h
@@ -14,7 +14,7 @@
#define XML_CONVERSIONS_H
#define DD4HEP_CONVERSION_NS xml
-#include "Parsers/detail/Conversions.h"
+#include <Parsers/detail/Conversions.h>
#undef DD4HEP_CONVERSION_NS
#endif // XML_CONVERSIONS_H
diff --git a/DDCore/include/XML/DocumentHandler.h b/DDCore/include/XML/DocumentHandler.h
index 8b7515cd2..e57442d8e 100644
--- a/DDCore/include/XML/DocumentHandler.h
+++ b/DDCore/include/XML/DocumentHandler.h
@@ -15,7 +15,7 @@
#define XML_DOCUMENTHANDLER_H
// Framework include files
-#include "XML/XMLElements.h"
+#include <XML/XMLElements.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/XML/Helper.h b/DDCore/include/XML/Helper.h
index 9438557a8..e0960f222 100644
--- a/DDCore/include/XML/Helper.h
+++ b/DDCore/include/XML/Helper.h
@@ -14,9 +14,9 @@
#define XML_HELPER_H
// Framework include files
-#include "XML/XML.h"
-#include "DD4hep/Detector.h"
-#include "DD4hep/DD4hepUnits.h"
+#include <XML/XML.h>
+#include <DD4hep/Detector.h>
+#include <DD4hep/DD4hepUnits.h>
/// Namespace for the AIDA detector description toolkit
namespace dd4hep {
diff --git a/DDCore/include/XML/Printout.h b/DDCore/include/XML/Printout.h
index ae9b3b255..37d3f9948 100644
--- a/DDCore/include/XML/Printout.h
+++ b/DDCore/include/XML/Printout.h
@@ -19,6 +19,6 @@
*
* See the externalized header in doc/externalize for details.
*/
-#include "Parsers/Printout.h"
+#include <Parsers/Printout.h>
#endif // XML_PRINTOUT_H
diff --git a/DDCore/include/XML/Utilities.h b/DDCore/include/XML/Utilities.h
index 0fc046a88..fb07b29db 100644
--- a/DDCore/include/XML/Utilities.h
+++ b/DDCore/include/XML/Utilities.h
@@ -15,10 +15,10 @@
#define XML_UTILITIES_H
// Framework include files
-#include "XML/Conversions.h"
-#include "XML/XMLElements.h"
-#include "XML/VolumeBuilder.h"
-#include "DD4hep/Detector.h"
+#include <XML/Conversions.h>
+#include <XML/XMLElements.h>
+#include <XML/VolumeBuilder.h>
+#include <DD4hep/Detector.h>
// C/C++ include files
#include <set>
diff --git a/DDCore/include/XML/VolumeBuilder.h b/DDCore/include/XML/VolumeBuilder.h
index 777626314..945887acc 100644
--- a/DDCore/include/XML/VolumeBuilder.h
+++ b/DDCore/include/XML/VolumeBuilder.h
@@ -14,9 +14,9 @@
#define XML_VOLUMEBUILDER_H
// Framework include files
-#include "XML/XMLElements.h"
-#include "XML/XMLDetector.h"
-#include "DD4hep/Detector.h"
+#include <XML/XMLElements.h>
+#include <XML/XMLDetector.h>
+#include <DD4hep/Detector.h>
// C/C++ include files
#include <set>
diff --git a/DDCore/include/XML/XML.h b/DDCore/include/XML/XML.h
index 8a7ef3379..76fba2543 100644
--- a/DDCore/include/XML/XML.h
+++ b/DDCore/include/XML/XML.h
@@ -14,11 +14,11 @@
#ifndef XML_XML_H
#define XML_XML_H
-#include "XML/XMLTags.h"
-#include "XML/XMLDimension.h"
-#include "XML/XMLDetector.h"
-#include "XML/XMLChildValue.h"
-#include "XML/DocumentHandler.h"
+#include <XML/XMLTags.h>
+#include <XML/XMLDimension.h>
+#include <XML/XMLDetector.h>
+#include <XML/XMLChildValue.h>
+#include <XML/DocumentHandler.h>
// Useful shortcuts to process XML structures.
typedef dd4hep::xml::Strng_t Unicode;
diff --git a/DDCore/include/XML/XMLChildValue.h b/DDCore/include/XML/XMLChildValue.h
index 917b4d0e2..39596e9c0 100644
--- a/DDCore/include/XML/XMLChildValue.h
+++ b/DDCore/include/XML/XMLChildValue.h
@@ -15,10 +15,10 @@
#define XML_XMLCHILDVALUE_H
// Framework include files
-#include "XML/XMLTags.h"
+#include <XML/XMLTags.h>
#define DD4HEP_DIMENSION_NS xml
-#include "Parsers/detail/ChildValue.h"
+#include <Parsers/detail/ChildValue.h>
#undef DD4HEP_DIMENSION_NS
#endif // XML_XMLCHILDVALUE_H
diff --git a/DDCore/include/XML/XMLChildValue.inl b/DDCore/include/XML/XMLChildValue.inl
index 7927acab5..f7ab057ec 100644
--- a/DDCore/include/XML/XMLChildValue.inl
+++ b/DDCore/include/XML/XMLChildValue.inl
@@ -15,10 +15,10 @@
#define DD4HEP_XML_XMLCHILDVALUE_INL
// Framework include files
-#include "XML/XMLChildValue.h"
+#include <XML/XMLChildValue.h>
#define DD4HEP_DIMENSION_NS xml
-#include "Parsers/detail/ChildValue.inl"
+#include <Parsers/detail/ChildValue.inl>
#undef DD4HEP_DIMENSION_NS
#endif /* DD4HEP_XML_XMLCHILDVALUE_INL */
diff --git a/DDCore/include/XML/XMLDetector.h b/DDCore/include/XML/XMLDetector.h
index 49d08232c..bac613f46 100644
--- a/DDCore/include/XML/XMLDetector.h
+++ b/DDCore/include/XML/XMLDetector.h
@@ -14,10 +14,10 @@
#define XML_XMLDETECTOR_H
// Framework include files
-#include "XML/XMLDimension.h"
+#include <XML/XMLDimension.h>
#define DD4HEP_DIMENSION_NS xml
-#include "Parsers/detail/Detector.h"
+#include <Parsers/detail/Detector.h>
#undef DD4HEP_DIMENSION_NS
#endif // XML_XMLDETECTOR_H
diff --git a/DDCore/include/XML/XMLDimension.h b/DDCore/include/XML/XMLDimension.h
index c7ec04f24..819036f7d 100644
--- a/DDCore/include/XML/XMLDimension.h
+++ b/DDCore/include/XML/XMLDimension.h
@@ -14,11 +14,11 @@
#define XML_XMLDIMENSION_H
// Framework include files
-#include "XML/XMLElements.h"
-#include "XML/XMLTags.h"
+#include <XML/XMLElements.h>
+#include <XML/XMLTags.h>
#define DD4HEP_DIMENSION_NS xml
-#include "Parsers/detail/Dimension.h"
+#include <Parsers/detail/Dimension.h>
#undef DD4HEP_DIMENSION_NS
#endif // XML_XMLDIMENSION_H
diff --git a/DDCore/include/XML/XMLDimension.inl b/DDCore/include/XML/XMLDimension.inl
index 3c962a7e3..79ce42ad8 100644
--- a/DDCore/include/XML/XMLDimension.inl
+++ b/DDCore/include/XML/XMLDimension.inl
@@ -14,10 +14,10 @@
#ifndef DD4HEP_XMLDIMENSION_INL
#define DD4HEP_XMLDIMENSION_INL
-#include "XML/XMLDimension.h"
+#include <XML/XMLDimension.h>
#define DD4HEP_DIMENSION_NS xml
-#include "Parsers/detail/Dimension.inl"
+#include <Parsers/detail/Dimension.inl>
#undef DD4HEP_DIMENSION_NS
#endif /* DD4HEP_XMLDIMENSION_INL */
diff --git a/DDCore/include/XML/XMLElements.h b/DDCore/include/XML/XMLElements.h
index 954f5f359..2db5332f9 100644
--- a/DDCore/include/XML/XMLElements.h
+++ b/DDCore/include/XML/XMLElements.h
@@ -20,7 +20,7 @@
#include <stdexcept>
// Framework include files
-#include "XML/config.h"
+#include <XML/config.h>
#ifndef RAD_2_DEGREE
#define RAD_2_DEGREE 57.295779513082320876798154814105
diff --git a/DDCore/include/XML/XMLParsers.h b/DDCore/include/XML/XMLParsers.h
index 1f9b0ee81..e3d0e54d5 100644
--- a/DDCore/include/XML/XMLParsers.h
+++ b/DDCore/include/XML/XMLParsers.h
@@ -16,8 +16,8 @@
#define XML_XMLPARSERS_H
// Framework include files
-#include "DD4hep/AlignmentData.h"
-#include "XML/XMLElements.h"
+#include <DD4hep/AlignmentData.h>
+#include <XML/XMLElements.h>
// C/C++ include files
diff --git a/DDCore/include/XML/XMLTags.h b/DDCore/include/XML/XMLTags.h
index 7e2b88943..1e63e5a60 100644
--- a/DDCore/include/XML/XMLTags.h
+++ b/DDCore/include/XML/XMLTags.h
@@ -17,7 +17,7 @@
#define DECLARE_UNICODE_TAG(x) namespace dd4hep { namespace xml { extern const Tag_t Unicode_##x (#x); }}
// Framework include files
-#include "XML/XMLElements.h"
+#include <XML/XMLElements.h>
#define UNICODE(x) extern const Tag_t Unicode_##x
/// Namespace for the AIDA detector description toolkit
@@ -25,7 +25,7 @@ namespace dd4hep {
/// Namespace for the AIDA detector description toolkit supporting XML utilities
namespace xml {
-#include "XML/UnicodeValues.h"
+#include <XML/UnicodeValues.h>
}
}
diff --git a/DDCore/include/XML/config.h b/DDCore/include/XML/config.h
index 62e75f04c..ec7bc54ba 100644
--- a/DDCore/include/XML/config.h
+++ b/DDCore/include/XML/config.h
@@ -17,7 +17,7 @@
#ifndef XML_CONFIG_H
#define XML_CONFIG_H
-#include "Parsers/config.h"
+#include <Parsers/config.h>
#if defined(DD4HEP_USE_TINYXML)
#define __TIXML__
diff --git a/DDCore/src/AlignmentsCalculator.cpp.old b/DDCore/src/AlignmentsCalculator.cpp.old
deleted file mode 100644
index 682f13459..000000000
--- a/DDCore/src/AlignmentsCalculator.cpp.old
+++ /dev/null
@@ -1,291 +0,0 @@
-//==========================================================================
-// AIDA Detector description implementation
-//--------------------------------------------------------------------------
-// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
-// All rights reserved.
-//
-// For the licensing terms see $DD4hepINSTALL/LICENSE.
-// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
-//
-// Author : M.Frank
-//
-//==========================================================================
-
-// Framework include files
-#include "DD4hep/AlignmentsCalculator.h"
-#include "DD4hep/Printout.h"
-#include "DD4hep/Conditions.h"
-#include "DD4hep/ConditionsMap.h"
-#include "DD4hep/InstanceCount.h"
-#include "DD4hep/MatrixHelpers.h"
-#include "DD4hep/detail/AlignmentsInterna.h"
-
-using namespace dd4hep;
-using namespace dd4hep::align;
-typedef AlignmentsCalculator::Result Result;
-
-/// Namespace for the AIDA detector description toolkit
-namespace dd4hep {
-
- /// Namespace for the alignment part of the AIDA detector description toolkit
- namespace align {
-
- /// Anonymous implementation classes
- namespace {
- static Delta identity_delta;
-
- /// Alignment calculator.
- /**
- * Uses internally the conditions mechanism to calculator the alignment conditions.
- *
- * \author M.Frank
- * \version 1.0
- * \ingroup DD4HEP_ALIGNMENTS
- */
- class Calculator {
- public:
- class Entry;
- class Context;
-
- public:
- /// Initializing constructor
- Calculator() = default;
- /// Default destructor
- ~Calculator() = default;
- /// Compute the alignment delta for one detector element and it's alignment condition
- void computeDelta(const Delta& delta, TGeoHMatrix& tr_delta) const;
- /// Compute the transformation from the closest detector element of the alignment to the world system
- Result to_world(Context& context, DetElement det, TGeoHMatrix& mat) const;
- /// Compute all alignment conditions of the lower levels
- Result compute(Context& context, Entry& entry) const;
- /// Resolve child dependencies for a given context
- void resolve(Context& context, DetElement child) const;
- };
-
- class Calculator::Entry {
- public:
- DetElement::Object* det = 0;
- const Delta* delta = 0;
- AlignmentCondition::Object* cond = 0;
- unsigned char key = 0, valid = 0, created = 0, _pad[1];
- Entry(DetElement d, const Delta* del) : det(d.ptr()), delta(del), key(d.key()) {}
- };
-
- class Calculator::Context {
- public:
- struct PathOrdering {
- bool operator()(const DetElement& a, const DetElement& b) const
- { return a.path() < b.path(); }
- };
- typedef std::map<DetElement,size_t,PathOrdering> DetectorMap;
- typedef std::map<unsigned int,size_t> Keys;
- typedef std::vector<Entry> Entries;
-
- DetectorMap detectors;
- Keys keys;
- Entries entries;
- ConditionsMap& mapping;
- Context(ConditionsMap& m) : mapping(m) {
- InstanceCount::increment(this);
- }
- ~Context() {
- InstanceCount::decrement(this);
- }
- void insert(DetElement det, const Delta* delta) {
- if ( det.isValid() ) {
- Entry entry(det,delta);
- detectors.insert(std::make_pair(det, entries.size()));
- keys.insert(std::make_pair(entry.key, entries.size()));
- entries.insert(entries.end(), entry);
- return;
- }
- except("AlignContext","Failed to add entry: invalid detector handle!");
- }
- };
- }
- } /* End namespace align */
-} /* End namespace dd4hep */
-
-static PrintLevel s_PRINT = WARNING;
-//static PrintLevel s_PRINT = INFO;
-
-Result Calculator::to_world(Context& context,
- DetElement det,
- TGeoHMatrix& delta_to_world) const
-{
- Result result;
- DetElement par = det.parent();
-
- while( par.isValid() ) {
- // Mapping creation mode:
- // If we find that the parent also got updated, directly take this transformation.
- // Since we compute top-down, it is already valid!
- Context::Keys::const_iterator i = context.keys.find(par.key());
- if ( i != context.keys.end() ) {
- Entry& e = context.entries[(*i).second];
- // The parent entry is (not yet) valid. need to compute it first
- if ( 0 == e.valid ) {
- result += compute(context, e);
- }
- AlignmentCondition cond(e.cond);
- AlignmentData& align(cond.data());
- if ( s_PRINT <= INFO ) {
- ::printf("Multiply-left ALIGNMENT %s:", det.path().c_str()); delta_to_world.Print();
- ::printf(" with ALIGN(world) %s :", par.path().c_str()); align.worldDelta.Print();
- }
- delta_to_world.MultiplyLeft(&align.worldDelta);
- if ( s_PRINT <= INFO ) {
- ::printf(" Result :"); delta_to_world.Print();
- }
- ++result.computed;
- return result;
- }
- // Mapping update mode:
- // Check if there is already a transformation in the cache. If yes, take it.
- // We assume it is a good one, because higher level changes are already processed.
- AlignmentCondition cond = context.mapping.get(par,Keys::alignmentKey);
- if ( cond.isValid() ) {
- AlignmentData& align(cond.data());
- if ( s_PRINT <= INFO ) {
- ::printf("Multiply-left ALIGNMENT %s:", det.path().c_str()); delta_to_world.Print();
- ::printf(" with ALIGN(world) %s :", par.path().c_str()); align.worldDelta.Print();
- }
- delta_to_world.MultiplyLeft(&align.worldDelta);
- if ( s_PRINT <= INFO ) {
- ::printf(" Result :"); delta_to_world.Print();
- }
- ++result.computed;
- return result;
- }
- // There is no special alignment for this detector element.
- // Hence to nominal (relative) transformation to the parent is valid
- if ( s_PRINT <= INFO ) {
- ::printf("Multiply-left ALIGNMENT %s:", det.path().c_str()); delta_to_world.Print();
- ::printf(" with NOMINAL(det) %s :", par.path().c_str());
- par.nominal().detectorTransformation().Print();
- }
- delta_to_world.MultiplyLeft(&par.nominal().detectorTransformation());
- if ( s_PRINT <= INFO ) {
- ::printf(" Result :"); delta_to_world.Print();
- }
- par = par.parent();
- }
- ++result.computed;
- return result;
-}
-
-/// Compute the alignment delta for one detector element and it's alignment condition
-void Calculator::computeDelta(const Delta& delta,
- TGeoHMatrix& tr_delta) const
-{
- const Position& pos = delta.translation;
- const Translation3D& piv = delta.pivot;
- const RotationZYX& rot = delta.rotation;
-
- switch(delta.flags) {
- case Delta::HAVE_TRANSLATION+Delta::HAVE_ROTATION+Delta::HAVE_PIVOT:
- detail::matrix::_transform(tr_delta, Transform3D(Translation3D(pos)*piv*rot*(piv.Inverse())));
- break;
- case Delta::HAVE_TRANSLATION+Delta::HAVE_ROTATION:
- detail::matrix::_transform(tr_delta, Transform3D(rot,pos));
- break;
- case Delta::HAVE_ROTATION+Delta::HAVE_PIVOT:
- detail::matrix::_transform(tr_delta, Transform3D(piv*rot*(piv.Inverse())));
- break;
- case Delta::HAVE_ROTATION:
- detail::matrix::_transform(tr_delta, rot);
- break;
- case Delta::HAVE_TRANSLATION:
- detail::matrix::_transform(tr_delta, pos);
- break;
- default:
- break;
- }
-}
-
-/// Compute all alignment conditions of the lower levels
-Result Calculator::compute(Context& context, Entry& e) const {
- Result result;
- DetElement det = e.det;
-
- if ( e.valid == 1 ) {
- printout(DEBUG,"ComputeAlignment","================ IGNORE %s (already valid)",det.path().c_str());
- return result;
- }
- AlignmentCondition c = context.mapping.get(e.det, Keys::alignmentKey);
- AlignmentCondition cond = c.isValid() ? c : AlignmentCondition("alignment");
- AlignmentData& align = cond.data();
- const Delta* delta = e.delta ? e.delta : &identity_delta;
- TGeoHMatrix tr_delta;
-
- printout(DEBUG,"ComputeAlignment",
- "============================== Compute transformation of %s",det.path().c_str());
- e.valid = 1;
- e.cond = cond.ptr();
- computeDelta(*delta, tr_delta);
- align.delta = *delta;
- align.worldDelta = tr_delta;
- result += to_world(context, det, align.worldDelta);
- align.worldTrafo = det.nominal().worldTransformation()*align.worldDelta;
- align.detectorTrafo = det.nominal().detectorTransformation()*tr_delta;
- align.trToWorld = detail::matrix::_transform(&align.worldDelta);
- // Update mapping if the condition is freshly created
- if ( !c.isValid() ) {
- e.created = 1;
- cond->hash = ConditionKey(e.det,Keys::alignmentKey).hash;
- context.mapping.insert(e.det, Keys::alignmentKey, cond);
- }
- if ( s_PRINT <= INFO ) {
- printout(INFO,"ComputeAlignment","Level:%d Path:%s DetKey:%08X: Cond:%s key:%16llX",
- det.level(), det.path().c_str(), det.key(),
- yes_no(e.delta != 0), (long long int)cond.key());
- if ( s_PRINT <= DEBUG ) {
- ::printf("DetectorTrafo: '%s' -> '%s' ",det.path().c_str(), det.parent().path().c_str());
- det.nominal().detectorTransformation().Print();
- ::printf("Delta: '%s' ",det.path().c_str()); tr_delta.Print();
- ::printf("World-Delta: '%s' ",det.path().c_str()); align.worldDelta.Print();
- ::printf("Nominal: '%s' ",det.path().c_str()); det.nominal().worldTransformation().Print();
- ::printf("Result: '%s' ",det.path().c_str()); align.worldTrafo.Print();
- }
- }
- return result;
-}
-
-/// Resolve child dependencies for a given context
-void Calculator::resolve(Context& context, DetElement detector) const {
- auto children = detector.children();
- auto item = context.detectors.find(detector);
- if ( item == context.detectors.end() ) context.insert(detector,0);
- for(const auto& c : children )
- resolve(context, c.second);
-}
-
-/// Compute all alignment conditions of the internal dependency list
-Result AlignmentsCalculator::compute(const std::map<DetElement, Delta>& deltas,
- ConditionsMap& alignments) const
-{
- Result result;
- Calculator obj;
- Calculator::Context context(alignments);
- // This is a tricky one. We absolutely need the detector elements ordered
- // by their depth aka. the distance to /world.
- // Unfortunately one cannot use the raw pointer of the DetElement here,
- // But has to insert them in a map which is ordered by the DetElement path.
- //
- // Otherwise memory randomization gives us the wrong order and the
- // corrections are calculated in the wrong order ie. not top -> down the
- // hierarchy, but in "some" order depending on the pointer values!
- //
- std::map<DetElement,Delta,Calculator::Context::PathOrdering> ordered_deltas;
-
- for( const auto& i : deltas )
- ordered_deltas.insert(i);
-
- for( const auto& i : ordered_deltas )
- context.insert(i.first, &(i.second));
- for( const auto& i : ordered_deltas )
- obj.resolve(context,i.first);
- for( auto& i : context.entries )
- result += obj.compute(context, i);
- return result;
-}
diff --git a/DDCore/src/Handle.cpp b/DDCore/src/Handle.cpp
index 2fa5b4b1b..8d415e35f 100644
--- a/DDCore/src/Handle.cpp
+++ b/DDCore/src/Handle.cpp
@@ -24,7 +24,7 @@
#include <cstdio>
#if !defined(WIN32) && !defined(__ICC)
-#include "cxxabi.h"
+#include <cxxabi.h>
#endif
namespace dd4hep {
@@ -377,7 +377,7 @@ namespace dd4hep {
}
}
-#include "DDSegmentation/Segmentation.h"
+#include <DDSegmentation/Segmentation.h>
typedef DDSegmentation::Segmentation _Segmentation;
namespace dd4hep {
template <> void Handle<_Segmentation>::assign(_Segmentation* s, const std::string& n, const std::string&) {
diff --git a/DDCore/src/IDDescriptor.cpp b/DDCore/src/IDDescriptor.cpp
index 0b0d494e6..410ee8d7e 100644
--- a/DDCore/src/IDDescriptor.cpp
+++ b/DDCore/src/IDDescriptor.cpp
@@ -12,12 +12,12 @@
//==========================================================================
// Framework include files
-#include "DD4hep/IDDescriptor.h"
-#include "DD4hep/detail/Handle.inl"
-#include "DD4hep/detail/ObjectsInterna.h"
-#include "DD4hep/InstanceCount.h"
-#include "DD4hep/Volumes.h"
-#include "DD4hep/Printout.h"
+#include <DD4hep/IDDescriptor.h>
+#include <DD4hep/detail/Handle.inl>
+#include <DD4hep/detail/ObjectsInterna.h>
+#include <DD4hep/InstanceCount.h>
+#include <DD4hep/Volumes.h>
+#include <DD4hep/Printout.h>
// C/C++ include files
#include <stdexcept>
diff --git a/DDCore/src/JSON/Helpers.cpp b/DDCore/src/JSON/Helpers.cpp
index 8c172d166..8a22db3c3 100644
--- a/DDCore/src/JSON/Helpers.cpp
+++ b/DDCore/src/JSON/Helpers.cpp
@@ -19,5 +19,5 @@
#define DD4HEP_DIMENSION_NS json
using namespace dd4hep::DD4HEP_DIMENSION_NS;
-#include "Parsers/detail/Dimension.imp"
-#include "Parsers/detail/ChildValue.imp"
+#include <Parsers/detail/Dimension.imp>
+#include <Parsers/detail/ChildValue.imp>
diff --git a/DDCore/src/ObjectExtensions.cpp b/DDCore/src/ObjectExtensions.cpp
index 9979aca91..66ae32708 100644
--- a/DDCore/src/ObjectExtensions.cpp
+++ b/DDCore/src/ObjectExtensions.cpp
@@ -12,10 +12,10 @@
//==========================================================================
// Framework include files
-#include "DD4hep/ObjectExtensions.h"
-#include "DD4hep/InstanceCount.h"
-#include "DD4hep/Primitives.h"
-#include "DD4hep/Printout.h"
+#include <DD4hep/ObjectExtensions.h>
+#include <DD4hep/InstanceCount.h>
+#include <DD4hep/Primitives.h>
+#include <DD4hep/Printout.h>
using namespace dd4hep;
diff --git a/DDCore/src/Plugins.cpp b/DDCore/src/Plugins.cpp
index 30de1a2c0..4bdc3230b 100644
--- a/DDCore/src/Plugins.cpp
+++ b/DDCore/src/Plugins.cpp
@@ -39,9 +39,9 @@ bool PluginService::setDebug(bool new_value) {
#define DD4HEP_PARSERS_NO_ROOT
#endif
-#include "DD4hep/Printout.h"
+#include <DD4hep/Printout.h>
#if !defined(DD4HEP_PARSERS_NO_ROOT)
-#include "TSystem.h"
+#include <TSystem.h>
#else
#include <dlfcn.h>
#endif
diff --git a/DDCore/src/PropertyDictionary.h b/DDCore/src/PropertyDictionary.h
index 95848f62c..434ca9ae9 100644
--- a/DDCore/src/PropertyDictionary.h
+++ b/DDCore/src/PropertyDictionary.h
@@ -26,7 +26,7 @@
#include <set>
#include <string>
-#include "TRint.h"
+#include <TRint.h>
namespace dd4hep {
namespace detail {}
}
diff --git a/DDCore/src/SegmentationsInterna.cpp b/DDCore/src/SegmentationsInterna.cpp
index c94e3f013..e4d40e499 100644
--- a/DDCore/src/SegmentationsInterna.cpp
+++ b/DDCore/src/SegmentationsInterna.cpp
@@ -15,7 +15,7 @@
#include <DD4hep/detail/SegmentationsInterna.h>
#include <DD4hep/InstanceCount.h>
-#include "DDSegmentation/Segmentation.h"
+#include <DDSegmentation/Segmentation.h>
using namespace dd4hep;
diff --git a/DDCore/src/XML/Detector.cpp b/DDCore/src/XML/Detector.cpp
index 1662debb3..983955029 100644
--- a/DDCore/src/XML/Detector.cpp
+++ b/DDCore/src/XML/Detector.cpp
@@ -19,5 +19,5 @@
#define DD4HEP_DIMENSION_NS xml
using namespace dd4hep::DD4HEP_DIMENSION_NS;
-#include "Parsers/detail/Detector.imp"
+#include <Parsers/detail/Detector.imp>
#endif
diff --git a/DDCore/src/XML/XMLElements.cpp b/DDCore/src/XML/XMLElements.cpp
index d2ac4360d..aad6f7142 100644
--- a/DDCore/src/XML/XMLElements.cpp
+++ b/DDCore/src/XML/XMLElements.cpp
@@ -13,20 +13,20 @@
// Framework include files
#ifdef DD4HEP_USE_TINYXML
-#include "XML/tinyxml.h"
+#include <XML/tinyxml.h>
#else
#include <xercesc/util/Xerces_autoconf_config.hpp>
-#include "xercesc/util/XMLString.hpp"
-#include "xercesc/dom/DOMElement.hpp"
-#include "xercesc/dom/DOMDocument.hpp"
-#include "xercesc/dom/DOMNodeList.hpp"
-#include "xercesc/dom/DOM.hpp"
-#include "XML/config.h"
+#include <xercesc/util/XMLString.hpp>
+#include <xercesc/dom/DOMElement.hpp>
+#include <xercesc/dom/DOMDocument.hpp>
+#include <xercesc/dom/DOMNodeList.hpp>
+#include <xercesc/dom/DOM.hpp>
+#include <XML/config.h>
#endif
-#include "XML/XMLElements.h"
-#include "XML/Printout.h"
-#include "XML/XMLTags.h"
+#include <XML/XMLElements.h>
+#include <XML/Printout.h>
+#include <XML/XMLTags.h>
// C/C++ include files
#include <iostream>
@@ -1266,7 +1266,7 @@ Handle_t Document::clone(Handle_t source) const {
}
#ifdef DD4HEP_USE_TINYXML
-#include "tinyxml_inl.h"
-#include "tinyxmlerror_inl.h"
-#include "tinyxmlparser_inl.h"
+#include <tinyxml_inl.h>
+#include <tinyxmlerror_inl.h>
+#include <tinyxmlparser_inl.h>
#endif
diff --git a/DDCore/src/XML/XMLHelpers.cpp b/DDCore/src/XML/XMLHelpers.cpp
index 59fa2b888..2cfb69412 100644
--- a/DDCore/src/XML/XMLHelpers.cpp
+++ b/DDCore/src/XML/XMLHelpers.cpp
@@ -12,12 +12,12 @@
//==========================================================================
// Framework include files
-#include "XML/XMLDimension.inl"
-#include "XML/XMLChildValue.inl"
+#include <XML/XMLDimension.inl>
+#include <XML/XMLChildValue.inl>
// Instantiate here the concrete implementations
#define DD4HEP_DIMENSION_NS xml
using namespace dd4hep::DD4HEP_DIMENSION_NS;
-#include "Parsers/detail/Dimension.imp"
-#include "Parsers/detail/ChildValue.imp"
+#include <Parsers/detail/Dimension.imp>
+#include <Parsers/detail/ChildValue.imp>
diff --git a/DDCore/src/XML/XMLParsers.cpp b/DDCore/src/XML/XMLParsers.cpp
index f3228de0f..ee8f6c0e8 100644
--- a/DDCore/src/XML/XMLParsers.cpp
+++ b/DDCore/src/XML/XMLParsers.cpp
@@ -15,13 +15,13 @@
#ifndef DD4HEP_NONE
// Framework include files
-#include "DD4hep/Objects.h"
-#include "DD4hep/Printout.h"
-#include "DD4hep/OpaqueData.h"
-#include "DD4hep/OpaqueDataBinder.h"
-#include "XML/XMLParsers.h"
-#include "XML/XMLDimension.h"
-#include "XML/DocumentHandler.h"
+#include <DD4hep/Objects.h>
+#include <DD4hep/Printout.h>
+#include <DD4hep/OpaqueData.h>
+#include <DD4hep/OpaqueDataBinder.h>
+#include <XML/XMLParsers.h>
+#include <XML/XMLDimension.h>
+#include <XML/DocumentHandler.h>
// C/C++ include files
diff --git a/DDCore/src/XML/XMLTags.cpp b/DDCore/src/XML/XMLTags.cpp
index 4ec2a13ce..4916e847e 100644
--- a/DDCore/src/XML/XMLTags.cpp
+++ b/DDCore/src/XML/XMLTags.cpp
@@ -12,10 +12,10 @@
//==========================================================================
// Framework include files
-#include "XML/XMLElements.h"
+#include <XML/XMLElements.h>
#ifndef __TIXML__
-#include "xercesc/util/XMLString.hpp"
-#include "xercesc/util/PlatformUtils.hpp"
+#include <xercesc/util/XMLString.hpp>
+#include <xercesc/util/PlatformUtils.hpp>
#endif
// C/C++ include files
@@ -66,7 +66,7 @@ namespace dd4hep {
/// Namespace for the AIDA detector description toolkit supporting XML utilities
namespace xml {
-#include "XML/UnicodeValues.h"
+#include <XML/UnicodeValues.h>
}
}
diff --git a/DDCore/src/XML/tinyxml_inl.h b/DDCore/src/XML/tinyxml_inl.h
index 9091b0764..a1ce86a5d 100644
--- a/DDCore/src/XML/tinyxml_inl.h
+++ b/DDCore/src/XML/tinyxml_inl.h
@@ -37,7 +37,7 @@
#include <iostream>
#endif
-#include "XML/tinyxml.h"
+#include <XML/tinyxml.h>
bool TiXmlBase::condenseWhiteSpace = true;
diff --git a/DDCore/src/XML/tinyxmlerror_inl.h b/DDCore/src/XML/tinyxmlerror_inl.h
index ad18d9434..0dee3836f 100644
--- a/DDCore/src/XML/tinyxmlerror_inl.h
+++ b/DDCore/src/XML/tinyxmlerror_inl.h
@@ -28,7 +28,7 @@
and include from "marlin/tinyxml.h"
*/
-#include "XML/tinyxml.h"
+#include <XML/tinyxml.h>
// The goal of the seperate error file is to make the first
diff --git a/DDCore/src/XML/tinyxmlparser_inl.h b/DDCore/src/XML/tinyxmlparser_inl.h
index 1613515ac..46ea282f4 100644
--- a/DDCore/src/XML/tinyxmlparser_inl.h
+++ b/DDCore/src/XML/tinyxmlparser_inl.h
@@ -32,7 +32,7 @@
#include <ctype.h>
#include <stddef.h>
-#include "XML/tinyxml.h"
+#include <XML/tinyxml.h>
//#define DEBUG_PARSER
#if defined( DEBUG_PARSER )
diff --git a/DDCore/src/gdml/DetElementCreator.cpp b/DDCore/src/gdml/DetElementCreator.cpp
index a9707616d..85c65aa92 100644
--- a/DDCore/src/gdml/DetElementCreator.cpp
+++ b/DDCore/src/gdml/DetElementCreator.cpp
@@ -18,8 +18,8 @@
#define DD4HEP_DETELEMENTCREATOR_H
// Framework include files
-#include "DD4hep/VolumeProcessor.h"
-#include "DD4hep/Printout.h"
+#include <DD4hep/VolumeProcessor.h>
+#include <DD4hep/Printout.h>
namespace dd4hep {
@@ -106,10 +106,10 @@ namespace dd4hep {
#endif /* DD4HEP_DETELEMENTCREATOR_H */
// Framework include files
-#include "DD4hep/detail/DetectorInterna.h"
-#include "DD4hep/DetFactoryHelper.h"
-#include "DD4hep/DetectorHelper.h"
-#include "DD4hep/Printout.h"
+#include <DD4hep/detail/DetectorInterna.h>
+#include <DD4hep/DetFactoryHelper.h>
+#include <DD4hep/DetectorHelper.h>
+#include <DD4hep/Printout.h>
// C/C++ include files
#include <sstream>
diff --git a/DDCore/src/gdml/DetNominalCreator.cpp b/DDCore/src/gdml/DetNominalCreator.cpp
index 0e0ec5de6..bf8bba476 100644
--- a/DDCore/src/gdml/DetNominalCreator.cpp
+++ b/DDCore/src/gdml/DetNominalCreator.cpp
@@ -18,7 +18,7 @@
#define DD4HEP_DETNOMINALCREATOR_H
// Framework include files
-#include "DD4hep/DetElement.h"
+#include <DD4hep/DetElement.h>
namespace dd4hep {
@@ -44,8 +44,8 @@ namespace dd4hep {
#endif /* DD4HEP_DETNOMINALCREATOR_H */
// Framework include files
-#include "DD4hep/DetectorProcessor.h"
-#include "DD4hep/DetFactoryHelper.h"
+#include <DD4hep/DetectorProcessor.h>
+#include <DD4hep/DetFactoryHelper.h>
// C/C++ include files
diff --git a/DDCore/src/gdml/ImportPlainRoot.cpp b/DDCore/src/gdml/ImportPlainRoot.cpp
index be60a8194..606d4c0f1 100644
--- a/DDCore/src/gdml/ImportPlainRoot.cpp
+++ b/DDCore/src/gdml/ImportPlainRoot.cpp
@@ -12,20 +12,20 @@
//==========================================================================
// Framework include files
-#include "DD4hep/Detector.h"
-#include "DD4hep/Memory.h"
-#include "DD4hep/DD4hepUI.h"
-#include "DD4hep/Factories.h"
-#include "DD4hep/Printout.h"
-#include "DD4hep/DetectorData.h"
-#include "DD4hep/DetectorTools.h"
+#include <DD4hep/Detector.h>
+#include <DD4hep/Memory.h>
+#include <DD4hep/DD4hepUI.h>
+#include <DD4hep/Factories.h>
+#include <DD4hep/Printout.h>
+#include <DD4hep/DetectorData.h>
+#include <DD4hep/DetectorTools.h>
// ROOT includes
-#include "TInterpreter.h"
-#include "TGeoElement.h"
-#include "TGeoManager.h"
-#include "TFile.h"
-#include "TUri.h"
+#include <TInterpreter.h>
+#include <TGeoElement.h>
+#include <TGeoManager.h>
+#include <TFile.h>
+#include <TUri.h>
using namespace std;
using namespace dd4hep;
diff --git a/DDCore/src/graphics/DrawBField.cpp b/DDCore/src/graphics/DrawBField.cpp
index 18b15f77f..a4434b511 100644
--- a/DDCore/src/graphics/DrawBField.cpp
+++ b/DDCore/src/graphics/DrawBField.cpp
@@ -12,10 +12,10 @@
//==========================================================================
// Framework includes
-#include "DD4hep/Printout.h"
-#include "DD4hep/FieldTypes.h"
-#include "DD4hep/MatrixHelpers.h"
-#include "DD4hep/DetFactoryHelper.h"
+#include <DD4hep/Printout.h>
+#include <DD4hep/FieldTypes.h>
+#include <DD4hep/MatrixHelpers.h>
+#include <DD4hep/DetFactoryHelper.h>
#include <cmath>
using namespace dd4hep;
diff --git a/DDCore/src/plugins/LCDD2Output.cpp b/DDCore/src/plugins/LCDD2Output.cpp
index ee7b10b18..a80de1091 100644
--- a/DDCore/src/plugins/LCDD2Output.cpp
+++ b/DDCore/src/plugins/LCDD2Output.cpp
@@ -12,18 +12,18 @@
//==========================================================================
// Framework includes
-#include "XML/Conversions.h"
-#include "DD4hep/Detector.h"
-#include "DD4hep/Objects.h"
-#include "DD4hep/Printout.h"
-#include "DD4hep/IDDescriptor.h"
+#include <XML/Conversions.h>
+#include <DD4hep/Detector.h>
+#include <DD4hep/Objects.h>
+#include <DD4hep/Printout.h>
+#include <DD4hep/IDDescriptor.h>
// ROOT includes
-#include "TMap.h"
-#include "TROOT.h"
-#include "TColor.h"
-#include "TGeoMatrix.h"
-#include "TGeoManager.h"
+#include <TMap.h>
+#include <TROOT.h>
+#include <TColor.h>
+#include <TGeoMatrix.h>
+#include <TGeoManager.h>
/// C/C++ include files
#include <iostream>
diff --git a/DDCore/src/plugins/LCDDConverter.h b/DDCore/src/plugins/LCDDConverter.h
index e553d8878..81ab66c76 100644
--- a/DDCore/src/plugins/LCDDConverter.h
+++ b/DDCore/src/plugins/LCDDConverter.h
@@ -15,9 +15,9 @@
#define DDCORE_SRC_PLUGINS_LCDDCONVERTER_H
// Framework include files
-#include "DD4hep/Detector.h"
-#include "DD4hep/GeoHandler.h"
-#include "DD4hep/DetFactoryHelper.h"
+#include <DD4hep/Detector.h>
+#include <DD4hep/GeoHandler.h>
+#include <DD4hep/DetFactoryHelper.h>
// C/C++ include files
#include <set>
diff --git a/DDCore/src/plugins/PandoraConverter.cpp b/DDCore/src/plugins/PandoraConverter.cpp
index b615701f6..e9475d037 100644
--- a/DDCore/src/plugins/PandoraConverter.cpp
+++ b/DDCore/src/plugins/PandoraConverter.cpp
@@ -14,9 +14,9 @@
#define DD4HEP_DDCORE_PANDORACONVERTER_H
// Framework include files
-#include "DD4hep/Detector.h"
-#include "DD4hep/GeoHandler.h"
-#include "DD4hep/DetFactoryHelper.h"
+#include <DD4hep/Detector.h>
+#include <DD4hep/GeoHandler.h>
+#include <DD4hep/DetFactoryHelper.h>
/*
* dd4hep namespace declaration
@@ -82,10 +82,10 @@ namespace dd4hep {
//==========================================================================
// Framework includes
-#include "DD4hep/Detector.h"
-#include "DD4hep/GeoHandler.h"
-#include "DD4hep/DetFactoryHelper.h"
-#include "XML/DocumentHandler.h"
+#include <DD4hep/Detector.h>
+#include <DD4hep/GeoHandler.h>
+#include <DD4hep/DetFactoryHelper.h>
+#include <XML/DocumentHandler.h>
// C/C++ include files
#include <stdexcept>
diff --git a/DDCore/src/python/PythonPlugin.cpp b/DDCore/src/python/PythonPlugin.cpp
index 70ecfe17d..eee8dfcf5 100644
--- a/DDCore/src/python/PythonPlugin.cpp
+++ b/DDCore/src/python/PythonPlugin.cpp
@@ -12,11 +12,11 @@
//==========================================================================
// Framework include files
-#include "DD4hep/Factories.h"
-#include "DD4hep/Printout.h"
+#include <DD4hep/Factories.h>
+#include <DD4hep/Printout.h>
// ROOT includes
-#include "TPython.h"
+#include <TPython.h>
using namespace std;
using namespace dd4hep;
diff --git a/DDCore/src/segmentations/BitField64.cpp b/DDCore/src/segmentations/BitField64.cpp
index 35bf19b1e..ac7543348 100644
--- a/DDCore/src/segmentations/BitField64.cpp
+++ b/DDCore/src/segmentations/BitField64.cpp
@@ -1,4 +1,14 @@
-#include "DDSegmentation/BitField64.h"
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
+#include <DDSegmentation/BitField64.h>
#include <cmath>
#include <algorithm>
diff --git a/DDCore/src/segmentations/BitFieldCoder.cpp b/DDCore/src/segmentations/BitFieldCoder.cpp
index 1c3fbed77..c35a9676e 100644
--- a/DDCore/src/segmentations/BitFieldCoder.cpp
+++ b/DDCore/src/segmentations/BitFieldCoder.cpp
@@ -1,4 +1,14 @@
-#include "DDSegmentation/BitFieldCoder.h"
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
+#include <DDSegmentation/BitFieldCoder.h>
#include <cmath>
#include <algorithm>
diff --git a/DDCore/src/segmentations/CartesianGrid.cpp b/DDCore/src/segmentations/CartesianGrid.cpp
index 0dc1ca2a9..7d53c2050 100644
--- a/DDCore/src/segmentations/CartesianGrid.cpp
+++ b/DDCore/src/segmentations/CartesianGrid.cpp
@@ -1,3 +1,13 @@
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
/*
* CartesianGrid.cpp
*
@@ -5,7 +15,7 @@
* Author: Christian Grefe, CERN
*/
-#include "DDSegmentation/CartesianGrid.h"
+#include <DDSegmentation/CartesianGrid.h>
namespace dd4hep {
namespace DDSegmentation {
diff --git a/DDCore/src/segmentations/CartesianGridXY.cpp b/DDCore/src/segmentations/CartesianGridXY.cpp
index 371828a6a..81d929be5 100644
--- a/DDCore/src/segmentations/CartesianGridXY.cpp
+++ b/DDCore/src/segmentations/CartesianGridXY.cpp
@@ -1,3 +1,13 @@
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
/*
* CartesianGridXY.cpp
*
@@ -5,7 +15,7 @@
* Author: Christian Grefe, CERN
*/
-#include "DDSegmentation/CartesianGridXY.h"
+#include <DDSegmentation/CartesianGridXY.h>
namespace dd4hep {
namespace DDSegmentation {
@@ -82,5 +92,5 @@ CellID CartesianGridXY::cellID(const Vector3D& localPosition,
} /* namespace dd4hep */
// This is done DDCore/src/plugins/ReadoutSegmentations.cpp so the plugin is not part of libDDCore
-// needs also #include "DD4hep/Factories.h"
+// needs also #include <DD4hep/Factories.h>
// DECLARE_SEGMENTATION(CartesianGridXY,dd4hep::create_segmentation<dd4hep::DDSegmentation::CartesianGridXY>)
diff --git a/DDCore/src/segmentations/CartesianGridXYStaggered.cpp b/DDCore/src/segmentations/CartesianGridXYStaggered.cpp
index 504794d7e..038e5ef8d 100644
--- a/DDCore/src/segmentations/CartesianGridXYStaggered.cpp
+++ b/DDCore/src/segmentations/CartesianGridXYStaggered.cpp
@@ -1,3 +1,13 @@
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
/*
* CartesianGridXYStaggered.cpp
*
@@ -5,7 +15,7 @@
* Author: Sebouh J. Paul, UCR
*/
-#include "DDSegmentation/CartesianGridXYStaggered.h"
+#include <DDSegmentation/CartesianGridXYStaggered.h>
namespace dd4hep {
namespace DDSegmentation {
diff --git a/DDCore/src/segmentations/CartesianGridXYZ.cpp b/DDCore/src/segmentations/CartesianGridXYZ.cpp
index a4bec58b4..73333c853 100644
--- a/DDCore/src/segmentations/CartesianGridXYZ.cpp
+++ b/DDCore/src/segmentations/CartesianGridXYZ.cpp
@@ -1,3 +1,13 @@
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
/*
* CartesianGridXYZ.cpp
*
@@ -5,7 +15,7 @@
* Author: Christian Grefe, CERN
*/
-#include "DDSegmentation/CartesianGridXYZ.h"
+#include <DDSegmentation/CartesianGridXYZ.h>
namespace dd4hep {
namespace DDSegmentation {
@@ -74,7 +84,3 @@ std::vector<double> CartesianGridXYZ::cellDimensions(const CellID&) const {
} /* namespace DDSegmentation */
} /* namespace dd4hep */
-
-// This is done DDCore/src/plugins/ReadoutSegmentations.cpp so the plugin is not part of libDDCore
-// needs also #include "DD4hep/Factories.h"
-// DECLARE_SEGMENTATION(CartesianGridXYZ,create_segmentation<dd4hep::DDSegmentation::CartesianGridXYZ>)
diff --git a/DDCore/src/segmentations/CartesianGridXZ.cpp b/DDCore/src/segmentations/CartesianGridXZ.cpp
index 2c151bb0a..b7327e9e7 100644
--- a/DDCore/src/segmentations/CartesianGridXZ.cpp
+++ b/DDCore/src/segmentations/CartesianGridXZ.cpp
@@ -1,3 +1,13 @@
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
/*
* CartesianGridXZ.cpp
*
@@ -5,7 +15,7 @@
* Author: Christian Grefe, CERN
*/
-#include "DDSegmentation/CartesianGridXZ.h"
+#include <DDSegmentation/CartesianGridXZ.h>
namespace dd4hep {
namespace DDSegmentation {
@@ -81,7 +91,3 @@ std::vector<double> CartesianGridXZ::cellDimensions(const CellID&) const {
} /* namespace DDSegmentation */
} /* namespace dd4hep */
-
-// This is done DDCore/src/plugins/ReadoutSegmentations.cpp so the plugin is not part of libDDCore
-// needs also #include "DD4hep/Factories.h"
-// DECLARE_SEGMENTATION(CartesianGridXZ,create_segmentation<dd4hep::DDSegmentation::CartesianGridXZ>)
diff --git a/DDCore/src/segmentations/CartesianGridYZ.cpp b/DDCore/src/segmentations/CartesianGridYZ.cpp
index 47204dcd7..9069f406f 100644
--- a/DDCore/src/segmentations/CartesianGridYZ.cpp
+++ b/DDCore/src/segmentations/CartesianGridYZ.cpp
@@ -1,3 +1,13 @@
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
/* CartesianGridYZ.cpp
*
* @date: Sep 03, 2014
@@ -6,7 +16,7 @@
* direkt copy of CartesianGridXY
* by Christian Grefe, CERN
*/
-#include "DDSegmentation/CartesianGridYZ.h"
+#include <DDSegmentation/CartesianGridYZ.h>
namespace dd4hep {
namespace DDSegmentation {
@@ -79,7 +89,3 @@ std::vector<double> CartesianGridYZ::cellDimensions(const CellID&) const {
} /* namespace DDSegmentation */
} /* namespace dd4hep */
-
-// This is done DDCore/src/plugins/ReadoutSegmentations.cpp so the plugin is not part of libDDCore
-// needs also #include "DD4hep/Factories.h"
-// DECLARE_SEGMENTATION(CartesianGridYZ,create_segmentation<dd4hep::DDSegmentation::CartesianGridYZ>)
diff --git a/DDCore/src/segmentations/CartesianStrip.cpp b/DDCore/src/segmentations/CartesianStrip.cpp
index ac1c750a5..cc2b145ec 100644
--- a/DDCore/src/segmentations/CartesianStrip.cpp
+++ b/DDCore/src/segmentations/CartesianStrip.cpp
@@ -1,3 +1,13 @@
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
/*
* CartesianStrip.cpp
*
@@ -6,7 +16,7 @@
* David Blyth, ANL
*/
-#include "DDSegmentation/CartesianStrip.h"
+#include <DDSegmentation/CartesianStrip.h>
namespace dd4hep {
namespace DDSegmentation {
diff --git a/DDCore/src/segmentations/CartesianStripX.cpp b/DDCore/src/segmentations/CartesianStripX.cpp
index f0e3743c3..c43065972 100644
--- a/DDCore/src/segmentations/CartesianStripX.cpp
+++ b/DDCore/src/segmentations/CartesianStripX.cpp
@@ -1,3 +1,13 @@
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
/*
* CartesianStripX.cpp
*
@@ -6,7 +16,7 @@
* David Blyth, ANL
*/
-#include "DDSegmentation/CartesianStripX.h"
+#include <DDSegmentation/CartesianStripX.h>
namespace dd4hep {
namespace DDSegmentation {
@@ -64,7 +74,3 @@ std::vector<double> CartesianStripX::cellDimensions(const CellID&) const {
} // namespace DDSegmentation
} /* namespace dd4hep */
-
-// This is done DDCore/src/plugins/ReadoutSegmentations.cpp so the plugin is not part of libDDCore
-// needs also #include "DD4hep/Factories.h"
-// DECLARE_SEGMENTATION(CartesianStripX,create_segmentation<dd4hep::DDSegmentation::CartesianStripX>)
diff --git a/DDCore/src/segmentations/CartesianStripY.cpp b/DDCore/src/segmentations/CartesianStripY.cpp
index 9366f8e26..ac9e7d797 100644
--- a/DDCore/src/segmentations/CartesianStripY.cpp
+++ b/DDCore/src/segmentations/CartesianStripY.cpp
@@ -1,3 +1,13 @@
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
/*
* CartesianStripY.cpp
*
@@ -6,7 +16,7 @@
* David Blyth, ANL
*/
-#include "DDSegmentation/CartesianStripY.h"
+#include <DDSegmentation/CartesianStripY.h>
namespace dd4hep {
namespace DDSegmentation {
@@ -65,6 +75,3 @@ std::vector<double> CartesianStripY::cellDimensions(const CellID&) const {
} // namespace DDSegmentation
} /* namespace dd4hep */
-// This is done DDCore/src/plugins/ReadoutSegmentations.cpp so the plugin is not part of libDDCore
-// needs also #include "DD4hep/Factories.h"
-// DECLARE_SEGMENTATION(CartesianStripY,create_segmentation<dd4hep::DDSegmentation::CartesianStripY>)
diff --git a/DDCore/src/segmentations/CartesianStripZ.cpp b/DDCore/src/segmentations/CartesianStripZ.cpp
index 3b5788299..fcc689932 100644
--- a/DDCore/src/segmentations/CartesianStripZ.cpp
+++ b/DDCore/src/segmentations/CartesianStripZ.cpp
@@ -1,3 +1,13 @@
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
/*
* CartesianStripZ.cpp
*
@@ -6,7 +16,7 @@
* David Blyth, ANL
*/
-#include "DDSegmentation/CartesianStripZ.h"
+#include <DDSegmentation/CartesianStripZ.h>
namespace dd4hep {
namespace DDSegmentation {
@@ -64,7 +74,3 @@ std::vector<double> CartesianStripZ::cellDimensions(const CellID&) const {
} // namespace DDSegmentation
} /* namespace dd4hep */
-
-// This is done DDCore/src/plugins/ReadoutSegmentations.cpp so the plugin is not part of libDDCore
-// needs also #include "DD4hep/Factories.h"
-// DECLARE_SEGMENTATION(CartesianStripZ,create_segmentation<dd4hep::DDSegmentation::CartesianStripZ>)
diff --git a/DDCore/src/segmentations/CylindricalSegmentation.cpp b/DDCore/src/segmentations/CylindricalSegmentation.cpp
index 8ed982b3b..223f0bf37 100644
--- a/DDCore/src/segmentations/CylindricalSegmentation.cpp
+++ b/DDCore/src/segmentations/CylindricalSegmentation.cpp
@@ -1,3 +1,13 @@
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
/*
* CylindricalSegmentation.cpp
*
@@ -5,7 +15,7 @@
* Author: Christian Grefe, CERN
*/
-#include "DDSegmentation/CylindricalSegmentation.h"
+#include <DDSegmentation/CylindricalSegmentation.h>
namespace dd4hep {
namespace DDSegmentation {
diff --git a/DDCore/src/segmentations/GridPhiEta.cpp b/DDCore/src/segmentations/GridPhiEta.cpp
index aeb75490c..e00a2577b 100644
--- a/DDCore/src/segmentations/GridPhiEta.cpp
+++ b/DDCore/src/segmentations/GridPhiEta.cpp
@@ -1,5 +1,15 @@
-#include "DDSegmentation/GridPhiEta.h"
-#include "DDSegmentation/SegmentationUtil.h"
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
+#include <DDSegmentation/GridPhiEta.h>
+#include <DDSegmentation/SegmentationUtil.h>
namespace dd4hep {
namespace DDSegmentation {
@@ -57,7 +67,3 @@ double GridPhiEta::phi(const CellID& cID) const {
}
}
}
-
-// This is done DDCore/src/plugins/ReadoutSegmentations.cpp so the plugin is not part of libDDCore
-// needs also #include "DD4hep/Factories.h"
-// DECLARE_SEGMENTATION(GridPhiEta,create_segmentation<dd4hep::DDSegmentation::GridPhiEta>)
diff --git a/DDCore/src/segmentations/GridRPhiEta.cpp b/DDCore/src/segmentations/GridRPhiEta.cpp
index 7da109951..f79aff295 100644
--- a/DDCore/src/segmentations/GridRPhiEta.cpp
+++ b/DDCore/src/segmentations/GridRPhiEta.cpp
@@ -1,5 +1,15 @@
-#include "DDSegmentation/GridRPhiEta.h"
-#include "DDSegmentation/SegmentationUtil.h"
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
+#include <DDSegmentation/GridRPhiEta.h>
+#include <DDSegmentation/SegmentationUtil.h>
namespace dd4hep {
namespace DDSegmentation {
@@ -50,6 +60,3 @@ double GridRPhiEta::r(const CellID& cID) const {
}
}
-// This is done DDCore/src/plugins/ReadoutSegmentations.cpp so the plugin is not part of libDDCore
-// needs also #include "DD4hep/Factories.h"
-// DECLARE_SEGMENTATION(GridRPhiEta,create_segmentation<dd4hep::DDSegmentation::GridRPhiEta>)
diff --git a/DDCore/src/segmentations/HexGrid.cpp b/DDCore/src/segmentations/HexGrid.cpp
index 5be6ea355..6235aefcd 100644
--- a/DDCore/src/segmentations/HexGrid.cpp
+++ b/DDCore/src/segmentations/HexGrid.cpp
@@ -12,8 +12,8 @@
* Created on: August 9, 2023
* Author: Sebouh J. Paul, UC Riverside
*/
-#include "DD4hep/Factories.h"
-#include "DDSegmentation/HexGrid.h"
+#include <DD4hep/Factories.h>
+#include <DDSegmentation/HexGrid.h>
namespace dd4hep {
namespace DDSegmentation {
diff --git a/DDCore/src/segmentations/MegatileLayerGridXY.cpp b/DDCore/src/segmentations/MegatileLayerGridXY.cpp
index 3ed0fb958..77a75fd48 100644
--- a/DDCore/src/segmentations/MegatileLayerGridXY.cpp
+++ b/DDCore/src/segmentations/MegatileLayerGridXY.cpp
@@ -1,3 +1,13 @@
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
/*
* MegatileLayerGridXY.cpp
*
@@ -186,7 +196,3 @@ namespace dd4hep {
} /* namespace DDSegmentation */
} /* namespace dd4hep */
-
-// This is done DDCore/src/plugins/ReadoutSegmentations.cpp so the plugin is not part of libDDCore
-// needs also #include "DD4hep/Factories.h"
-// DECLARE_SEGMENTATION(MegatileLayerGridXY,create_segmentation<dd4hep::DDSegmentation::MegatileLayerGridXY>)
diff --git a/DDCore/src/segmentations/MultiSegmentation.cpp b/DDCore/src/segmentations/MultiSegmentation.cpp
index c00b5ec4e..2b61cbbc9 100644
--- a/DDCore/src/segmentations/MultiSegmentation.cpp
+++ b/DDCore/src/segmentations/MultiSegmentation.cpp
@@ -1,3 +1,13 @@
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
/*
* MultiSegmentation.cpp
*
diff --git a/DDCore/src/segmentations/NoSegmentation.cpp b/DDCore/src/segmentations/NoSegmentation.cpp
index 2c4257f0c..d4ff39cf5 100644
--- a/DDCore/src/segmentations/NoSegmentation.cpp
+++ b/DDCore/src/segmentations/NoSegmentation.cpp
@@ -1,3 +1,13 @@
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
/*
* NoSegmentation.cpp
*
@@ -5,7 +15,7 @@
* Author: Christian Grefe, CERN
*/
-#include "DDSegmentation/NoSegmentation.h"
+#include <DDSegmentation/NoSegmentation.h>
namespace dd4hep {
namespace DDSegmentation {
@@ -40,6 +50,3 @@ namespace dd4hep {
} /* namespace DDSegmentation */
} /* namespace dd4hep */
-// This is done DDCore/src/plugins/ReadoutSegmentations.cpp so the plugin is not part of libDDCore
-// needs also #include "DD4hep/Factories.h"
-// DECLARE_SEGMENTATION(NoSegmentation,create_segmentation<dd4hep::DDSegmentation::NoSegmentation>)
diff --git a/DDCore/src/segmentations/PolarGrid.cpp b/DDCore/src/segmentations/PolarGrid.cpp
index ef858e554..51b0bd9f2 100644
--- a/DDCore/src/segmentations/PolarGrid.cpp
+++ b/DDCore/src/segmentations/PolarGrid.cpp
@@ -1,3 +1,13 @@
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
/*
* PolarGrid.cpp
*
@@ -5,7 +15,7 @@
* Author: Marko Petric
*/
-#include "DDSegmentation/PolarGrid.h"
+#include <DDSegmentation/PolarGrid.h>
namespace dd4hep {
namespace DDSegmentation {
diff --git a/DDCore/src/segmentations/PolarGridRPhi.cpp b/DDCore/src/segmentations/PolarGridRPhi.cpp
index 8ad947361..f549cde12 100644
--- a/DDCore/src/segmentations/PolarGridRPhi.cpp
+++ b/DDCore/src/segmentations/PolarGridRPhi.cpp
@@ -1,3 +1,13 @@
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
/*
* PolarGridRPhi.cpp
*
@@ -5,7 +15,7 @@
* Author: Marko Petric
*/
-#include "DDSegmentation/PolarGridRPhi.h"
+#include <DDSegmentation/PolarGridRPhi.h>
namespace dd4hep {
namespace DDSegmentation {
@@ -85,6 +95,3 @@ std::vector<double> PolarGridRPhi::cellDimensions(const CellID& cID) const {
} /* namespace DDSegmentation */
} /* namespace dd4hep */
-// This is done DDCore/src/plugins/ReadoutSegmentations.cpp so the plugin is not part of libDDCore
-// needs also #include "DD4hep/Factories.h"
-// DECLARE_SEGMENTATION(PolarGridRPhi,create_segmentation<dd4hep::DDSegmentation::PolarGridRPhi>)
diff --git a/DDCore/src/segmentations/PolarGridRPhi2.cpp b/DDCore/src/segmentations/PolarGridRPhi2.cpp
index adf4a4446..b294315ae 100644
--- a/DDCore/src/segmentations/PolarGridRPhi2.cpp
+++ b/DDCore/src/segmentations/PolarGridRPhi2.cpp
@@ -1,3 +1,13 @@
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
/*
* PolarGridRPhi2.cpp
*
@@ -5,7 +15,7 @@
* Author: Marko Petric, Andre Sailer
*/
-#include "DDSegmentation/PolarGridRPhi2.h"
+#include <DDSegmentation/PolarGridRPhi2.h>
namespace dd4hep {
namespace DDSegmentation {
@@ -106,7 +116,3 @@ std::vector<double> PolarGridRPhi2::cellDimensions(const CellID& cID) const {
} /* namespace DDSegmentation */
} /* namespace dd4hep */
-
-// This is done DDCore/src/plugins/ReadoutSegmentations.cpp so the plugin is not part of libDDCore
-// needs also #include "DD4hep/Factories.h"
-// DECLARE_SEGMENTATION(PolarGridRPhi2,create_segmentation<dd4hep::DDSegmentation::PolarGridRPhi2>)
diff --git a/DDCore/src/segmentations/ProjectiveCylinder.cpp b/DDCore/src/segmentations/ProjectiveCylinder.cpp
index 3819e4bad..dd014d81c 100644
--- a/DDCore/src/segmentations/ProjectiveCylinder.cpp
+++ b/DDCore/src/segmentations/ProjectiveCylinder.cpp
@@ -1,3 +1,13 @@
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
/*
* ProjectiveCylinder.cpp
*
@@ -5,8 +15,8 @@
* Author: Christian Grefe, CERN
*/
-#include "DDSegmentation/ProjectiveCylinder.h"
-#include "DDSegmentation/SegmentationUtil.h"
+#include <DDSegmentation/ProjectiveCylinder.h>
+#include <DDSegmentation/SegmentationUtil.h>
#define _USE_MATH_DEFINES
#include <cmath>
@@ -84,6 +94,3 @@ double ProjectiveCylinder::phi(const CellID& cID) const {
} /* namespace DDSegmentation */
} /* namespace dd4hep */
-// This is done DDCore/src/plugins/ReadoutSegmentations.cpp so the plugin is not part of libDDCore
-// needs also #include "DD4hep/Factories.h"
-// DECLARE_SEGMENTATION(ProjectiveCylinder,create_segmentation<dd4hep::DDSegmentation::ProjectiveCylinder>)
diff --git a/DDCore/src/segmentations/Segmentation.cpp b/DDCore/src/segmentations/Segmentation.cpp
index d69067470..834e8485e 100644
--- a/DDCore/src/segmentations/Segmentation.cpp
+++ b/DDCore/src/segmentations/Segmentation.cpp
@@ -1,3 +1,13 @@
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
/*
* Segmentation.cpp
*
@@ -5,7 +15,7 @@
* Author: Christian Grefe, CERN
*/
-#include "DDSegmentation/Segmentation.h"
+#include <DDSegmentation/Segmentation.h>
#include <iostream>
#include <sstream>
diff --git a/DDCore/src/segmentations/TiledLayerGridXY.cpp b/DDCore/src/segmentations/TiledLayerGridXY.cpp
index a3630381a..987f8eee6 100644
--- a/DDCore/src/segmentations/TiledLayerGridXY.cpp
+++ b/DDCore/src/segmentations/TiledLayerGridXY.cpp
@@ -1,3 +1,13 @@
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
/*
* TiledLayerGridXY.cpp
*
@@ -125,7 +135,3 @@ std::vector<double> TiledLayerGridXY::cellDimensions(const CellID&) const {
} /* namespace DDSegmentation */
} /* namespace dd4hep */
-
-// This is done DDCore/src/plugins/ReadoutSegmentations.cpp so the plugin is not part of libDDCore
-// needs also #include "DD4hep/Factories.h"
-// DECLARE_SEGMENTATION(TiledLayerGridXY,create_segmentation<dd4hep::DDSegmentation::TiledLayerGridXY>)
diff --git a/DDCore/src/segmentations/TiledLayerSegmentation.cpp b/DDCore/src/segmentations/TiledLayerSegmentation.cpp
index d2997687c..47a5f100f 100644
--- a/DDCore/src/segmentations/TiledLayerSegmentation.cpp
+++ b/DDCore/src/segmentations/TiledLayerSegmentation.cpp
@@ -1,3 +1,13 @@
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
/*
* TiledLayerSegmentation.cpp
*
@@ -5,7 +15,7 @@
* Author: cgrefe
*/
-#include "DDSegmentation/TiledLayerSegmentation.h"
+#include <DDSegmentation/TiledLayerSegmentation.h>
// C/C++ includes
#include <algorithm>
diff --git a/DDCore/src/segmentations/WaferGridXY.cpp b/DDCore/src/segmentations/WaferGridXY.cpp
index 608c97549..325945ff5 100644
--- a/DDCore/src/segmentations/WaferGridXY.cpp
+++ b/DDCore/src/segmentations/WaferGridXY.cpp
@@ -1,3 +1,13 @@
+//==========================================================================
+// AIDA Detector description implementation
+//--------------------------------------------------------------------------
+// Copyright (C) Organisation europeenne pour la Recherche nucleaire (CERN)
+// All rights reserved.
+//
+// For the licensing terms see $DD4hepINSTALL/LICENSE.
+// For the list of contributors see $DD4hepINSTALL/doc/CREDITS.
+//
+//==========================================================================
/*
* WaferGridXY.cpp
*
@@ -5,7 +15,7 @@
* Author: S. Lu, DESY
*/
-#include "DDSegmentation/WaferGridXY.h"
+#include <DDSegmentation/WaferGridXY.h>
namespace dd4hep {
namespace DDSegmentation {
@@ -128,7 +138,3 @@ std::vector<double> WaferGridXY::cellDimensions(const CellID&) const {
} /* namespace DDSegmentation */
} /* namespace dd4hep */
-
-// This is done DDCore/src/plugins/ReadoutSegmentations.cpp so the plugin is not part of libDDCore
-// needs also #include "DD4hep/Factories.h"
-// DECLARE_SEGMENTATION(WaferGridXY,create_segmentation<dd4hep::DDSegmentation::WaferGridXY>)
diff --git a/DDDigi/include/DDDigi/DigiAction.h b/DDDigi/include/DDDigi/DigiAction.h
index 31dfb86eb..cd1192a33 100644
--- a/DDDigi/include/DDDigi/DigiAction.h
+++ b/DDDigi/include/DDDigi/DigiAction.h
@@ -15,7 +15,7 @@
// Framework include files
#include <DD4hep/Printout.h>
-#include <DD4hep/ObjectExtensions.h>
+#include <DD4hep/ExtensionEntry.h>
#include <DD4hep/ComponentProperties.h>
#include <DDDigi/DigiContext.h>
@@ -118,12 +118,12 @@ namespace dd4hep {
/// Default destructor
virtual ~Extension() = default;
/// Wrapper for the object destruction
- virtual void* object() const override { return ptr; }
+ virtual void* object() const override { return ptr; }
/// Wrapper for the object destruction
- virtual void destruct() const override { delete ptr; }
- virtual void* copy(void*) const override { return nullptr; }
- virtual ExtensionEntry* clone(void*) const override { return nullptr; }
- virtual unsigned long long int hash64() const override { return uint64_t(ptr); }
+ virtual void destruct() const override { delete ptr; }
+ virtual void* copy(void*) const override { invalidCall("copy"); return nullptr; }
+ virtual ExtensionEntry* clone(void*) const override { invalidCall("clone"); return nullptr; }
+ virtual unsigned long long int hash64() const override { return uint64_t(ptr); }
};
@@ -144,8 +144,6 @@ namespace dd4hep {
std::string m_name;
/// Property pool
PropertyManager m_properties;
- ///
- std::vector<void*> m_opt_properties;
/// Object extensions if used
extensions_t m_extensions;
/// Reference count. Initial value: 1
@@ -255,21 +253,21 @@ namespace dd4hep {
/// Declare property
template <typename T> DigiAction& DigiAction::declareProperty(const std::string& nam, T& val) {
- m_properties.add(nam, val);
+ this->m_properties.add(nam, val);
return *this;
}
/// Declare property
template <typename T> DigiAction& DigiAction::declareProperty(const char* nam, T& val) {
- m_properties.add(nam, val);
+ this->m_properties.add(nam, val);
return *this;
}
/// Declare property
template <typename T> DigiAction& DigiAction::addProperty(const std::string& nam, T& val) {
void* ptr = ::operator new(sizeof(T));
T* prop = new(ptr) T(val);
- m_properties.add(nam, *prop);
- m_opt_properties.emplace_back(ptr);
+ this->m_properties.add(nam, *prop);
+ this->addExtension(prop);
return *this;
}
@@ -277,8 +275,8 @@ namespace dd4hep {
template <typename T> DigiAction& DigiAction::addProperty(const char* nam, T& val) {
void* ptr = ::operator new(sizeof(T));
T* prop = new(ptr) T(val);
- m_properties.add(nam, *prop);
- m_opt_properties.emplace_back(ptr);
+ this->m_properties.add(nam, *prop);
+ this->addExtension(prop);
return *this;
}
} // End namespace digi
diff --git a/DDDigi/src/DigiAction.cpp b/DDDigi/src/DigiAction.cpp
index 15371b964..645f5c890 100644
--- a/DDDigi/src/DigiAction.cpp
+++ b/DDDigi/src/DigiAction.cpp
@@ -49,7 +49,6 @@ DigiAction::~DigiAction() {
for( auto& ptr : m_extensions )
ptr.second->destruct();
m_extensions.clear();
- m_opt_properties.clear();
InstanceCount::decrement(this);
}
@@ -241,11 +240,9 @@ namespace dd4hep {
namespace digi {
template <typename VAL>
int add_action_property(DigiAction* action, const std::string& name, VAL value) {
- VAL* new_val = new VAL(value);
- action->addProperty(name, *(new_val));
- action->addExtension(new_val);
+ action->addProperty(name, value);
printout(INFO, "addProperty", "+++ Added property %s of type %s",
- name.c_str(), typeName(typeid(VAL)).c_str());
+ name.c_str(), typeName(typeid(VAL)).c_str());
return 1;
}
--
GitLab