From c8a425b30b3832d858045265c969b17cca1f6d82 Mon Sep 17 00:00:00 2001
From: Marko Petric <marko.petric@cern.ch>
Date: Mon, 12 Apr 2021 11:03:29 +0200
Subject: [PATCH] Fix bug reported by coverity as suggested by C. Jones
---
DDParsers/src/Evaluator/Evaluator.cpp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/DDParsers/src/Evaluator/Evaluator.cpp b/DDParsers/src/Evaluator/Evaluator.cpp
index 4ba4368c2..71bcd1b80 100644
--- a/DDParsers/src/Evaluator/Evaluator.cpp
+++ b/DDParsers/src/Evaluator/Evaluator.cpp
@@ -929,11 +929,10 @@ int Evaluator::setEnviron(const std::string& name, const std::string& value) co
//---------------------------------------------------------------------------
std::pair<int,std::string> Evaluator::getEnviron(const std::string& name) const {
- const char* env = nullptr;
std::pair<int,std::string> result;
auto env_status = object->getEnviron(name.c_str());
result.first = env_status.second;
- if ( env ) result.second = env_status.first;
+ if( env_status.first ) result.second = env_status.first;
return result;
}
--
GitLab