From e60168c3926a88da912164b7418cde3afbaca1e5 Mon Sep 17 00:00:00 2001
From: Andre Sailer <andre.philippe.sailer@cern.ch>
Date: Wed, 25 Mar 2015 17:32:15 +0000
Subject: [PATCH] Tube: Remove duplicate unit conversion
Don't convert units when calling the setDimension internal function.
Otherwise conversion is applied twice when setDimensions calls _setDimensions
---
DDCore/src/Shapes.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/DDCore/src/Shapes.cpp b/DDCore/src/Shapes.cpp
index ba3f2f710..cbfeff8db 100644
--- a/DDCore/src/Shapes.cpp
+++ b/DDCore/src/Shapes.cpp
@@ -261,7 +261,7 @@ ConeSegment& ConeSegment::setDimensions(double dz, double rmin1, double rmax1, d
void Tube::make(const string& nam, double rmin, double rmax, double z, double startPhi, double deltaPhi) {
//_assign(new TGeoTubeSeg(rmin,rmax,z,startPhi/dd4hep::deg,deltaPhi/dd4hep::deg),name,"tube",true);
_assign(new MyConeSeg(), nam, "tube", true);
- setDimensions(rmin, rmax, z, startPhi/dd4hep::deg, deltaPhi/dd4hep::deg);
+ setDimensions(rmin, rmax, z, startPhi, deltaPhi);
}
/// Set the tube dimensions
--
GitLab