From f2bbf5b06105d6d0515d4f4234ce09472bfdcc7a Mon Sep 17 00:00:00 2001
From: Andre Sailer <andre.philippe.sailer@cern.ch>
Date: Tue, 1 Dec 2015 15:55:51 +0000
Subject: [PATCH] DDSim: Add comments in code, remove FIXME that is fixed
---
DDSim/DD4hepSimulation.py | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/DDSim/DD4hepSimulation.py b/DDSim/DD4hepSimulation.py
index 801034188..a296135ed 100644
--- a/DDSim/DD4hepSimulation.py
+++ b/DDSim/DD4hepSimulation.py
@@ -168,7 +168,6 @@ class DD4hepSimulation(object):
parser.add_argument("--dumpSteeringFile", action="store_true", dest="dumpSteeringFile", default=self._dumpSteeringFile,
help="print an example steering file to stdout")
- #FIXME: Add all the things here, then they will show up in the help usage
#output, or do something smarter with fullHelp only for example
self.__addAllHelper( parser )
## now parse everything. The default values are now taken from the
@@ -623,15 +622,18 @@ SIM = DD4hepSimulation()
parValue, parDoc = valAndDoc
if parDoc:
steeringFileBase += "## %s\n" % "\n## ".join(parDoc.splitlines())
+ ## add quotes if it is a string
if isinstance( parValue, basestring ):
steeringFileBase += "SIM.%s.%s = \"%s\"\n" %(parName, opt, parValue)
else:
steeringFileBase += "SIM.%s.%s = %s\n" %(parName, opt, parValue)
else:
+ ## get the docstring from the command line parameter
optionObj = optionDict.get("--"+parName, None)
if isinstance(optionObj, argparse._StoreAction ):
steeringFileBase += "## %s\n" % "\n## ".join(optionObj.help.splitlines())
- if isinstance( parameter, basestring):
+ ## add quotes if it is a string
+ if isinstance(parameter, basestring):
steeringFileBase += "SIM.%s = \"%s\"" %( parName, str(parameter))
else:
steeringFileBase += "SIM.%s = %s" %( parName, str(parameter))
--
GitLab