- changed default unit for angles to be radians (tgeo::rad = 1.)
- enforce usage of units from TGeoUnits.h in xml expression evaluators - convert to degrees for angles in TGeoShapes constructors - NB: there is one inconsistency left here: angles returned from TGeoShapes are already in degrees, this is the one case where a quantity returned from DD4hep/TGeo does not have the default units - thus one should not write double phi = coneSeg.Phi1() / tgeo::rad ; but rather double phi = coneSeg.Phi1() * tgeo::deg ;
Showing
- DDCore/include/DD4hep/TGeoUnits.h 8 additions, 2 deletionsDDCore/include/DD4hep/TGeoUnits.h
- DDCore/include/XML/Evaluator.h 1 addition, 1 deletionDDCore/include/XML/Evaluator.h
- DDCore/src/Evaluator/setStdMath.cpp 11 additions, 4 deletionsDDCore/src/Evaluator/setStdMath.cpp
- DDCore/src/Evaluator/setSystemOfUnits.cpp 7 additions, 2 deletionsDDCore/src/Evaluator/setSystemOfUnits.cpp
- DDCore/src/ExpressionEvaluator.cpp 6 additions, 1 deletionDDCore/src/ExpressionEvaluator.cpp
- DDCore/src/Shapes.cpp 19 additions, 18 deletionsDDCore/src/Shapes.cpp
- DDTest/src/test_units.cc 4 additions, 0 deletionsDDTest/src/test_units.cc
Loading
Please register or sign in to comment