Skip to content
Snippets Groups Projects
  1. Apr 21, 2023
    • Andre Sailer's avatar
      Apply suggestions from code review · 223a4ca0
      Andre Sailer authored
      DDSim,Meta: Fix formatting for dict
      223a4ca0
    • scott snyder's avatar
      Fig setting of run/event number offsets from the ddsim command line. · c5030d4a
      scott snyder authored
      The ddsim --meta.runNumberOffset command-line argument doesn't work
      correctly (and similarly for event number).
      
      On a machine running
      
      ```
      LSB Version:    :core-4.1-amd64:core-4.1-ia32:core-4.1-noarch
      Distributor ID: Scientific
      Description:    Scientific Linux release 7.3 (Nitrogen)
      Release:        7.3
      Codename:       Nitrogen
      ```
      
      I do
      
      ```
      . /cvmfs/sw.hsf.org/key4hep/setup.sh
      ```
      
      The then command
      
      ```
      ddsim  --compactFile $LCGEO/FCCee/compact/FCCee_o1_v05/FCCee_o1_v05.xml -G -N10 --outputFile out.edm4hep.root --meta.runNumberOffset 735001  2>&1|tee log
      ```
      
      eventually crashes with the error
      
      ```
      Geant4UI         INFO  +++ EventAction> Install Geant4 control directory:/ddg4/EventAction/
      Traceback (most recent call last):
        File "/cvmfs/sw.hsf.org/spackages7/dd4hep/1.23/x86_64-centos7-gcc11.2.0-opt/q4qtg/bin/ddsim", line 25, in <module>
          RUNNER.run()
        File "/cvmfs/sw.hsf.org/spackages7/dd4hep/1.23/x86_64-centos7-gcc11.2.0-opt/q4qtg/lib/python3.10/site-packages/DDSim/DD4hepSimulation.py", line 368, in run
          e4Out.RunNumberOffset = self.meta.runNumberOffset if self.meta.runNumberOffset > 0 else 0
      TypeError: '>' not supported between instances of 'str' and 'int'
       *** Break *** segmentation violation
      ```
      
      The arguments are never converted from strings to integers.
      The change here fixes this.
      c5030d4a
  2. Mar 15, 2023
  3. Feb 23, 2023
  4. Feb 16, 2023
  5. Jan 18, 2023
  6. Dec 09, 2022
  7. Nov 26, 2022
  8. Nov 24, 2022
  9. Nov 22, 2022
  10. Nov 11, 2022
  11. Nov 10, 2022
  12. Oct 29, 2022
  13. Oct 22, 2022
  14. Sep 01, 2022
  15. Aug 25, 2022
  16. Aug 11, 2022
  17. Aug 10, 2022
  18. Aug 09, 2022
  19. Aug 05, 2022
Loading